Version 2.1.3

Author: konraddysput

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Backtrace Unity Release Notes
 
+## Version 2.1.3
+
+- `BacktraceUnhandledException` will generate environment stack trace if Unity stack trace is empty. BacktraceReport will still generate normalized fingerprint for unhandled exception without stack trace.
+- `BacktraceUnhandledException` will provide information from Unity Error logger in source code property, which should improve error analysis in web debugger.
+- `BacktraceAttributes` won't try to collect `Annotations` anymore.
+- `Annotations` won't use ComplexAttributes property anymore.
+
 ## Version 2.1.2
 
 - `BacktraceReport` will generate report fingerprint for exceptions without stack trace.

Runtime/Model/BacktraceData.cs

@@ -174,7 +174,12 @@ public static BacktraceData Deserialize(string json)
         /// </summary>
         private void SetThreadInformations()
         {
-            ThreadData = new ThreadData(Report.DiagnosticStack);
+            var faultingThread = 
+                Report.Exception is BacktraceUnhandledException 
+                && string.IsNullOrEmpty(Report.Exception.StackTrace)
+                ? false
+                : true;
+            ThreadData = new ThreadData(Report.DiagnosticStack, faultingThread);
             ThreadInformations = ThreadData.ThreadInformations;
             MainThread = ThreadData.MainThread;
             if (Report.Exception is BacktraceUnhandledException)
@@ -190,7 +195,7 @@ private void SetThreadInformations()
         private void SetAttributes(Dictionary<string, object> clientAttributes)
         {
             Attributes = new BacktraceAttributes(Report, clientAttributes);
-            Annotation = new Annotations(Attributes.ComplexAttributes);
+            Annotation = new Annotations();
         }
 
         /// <summary>
@@ -206,7 +211,7 @@ private void SetReportInformation()
             LangVersion = "Mono";
 #endif
 
-            AgentVersion = "2.1.2";
+            AgentVersion = "2.1.3";
             Classifier = Report.ExceptionTypeReport ? new[] { Report.Classifier } : null;
         }
     }

Runtime/Model/BacktraceUnhandledException.cs

@@ -43,9 +43,17 @@ public override string StackTrace
 
         public BacktraceUnhandledException(string message, string stacktrace) : base(message)
         {
-            _stacktrace = stacktrace;
             _message = message;
-            ConvertStackFrames();
+            if (!string.IsNullOrEmpty(stacktrace))
+            {
+                _stacktrace = stacktrace;
+                ConvertStackFrames();
+            } else
+            {
+                _stacktrace = string.Empty;
+                var backtraceStackTrace = new BacktraceStackTrace(null);
+                StackFrames = backtraceStackTrace.StackFrames;
+            }
             CreateUnhandledExceptionLogInformation();
         }
 
@@ -56,7 +64,7 @@ private void CreateUnhandledExceptionLogInformation()
         {
             SourceCode = new BacktraceSourceCode()
             {
-                Text = string.Format("Unity Exception:\n{0}\n{1}", _message, _stacktrace)
+                Text = string.Format("Unity exception information\nMessage :{0}\nStack trace :{1}", _message, _stacktrace)
             };
             // assign log information to first stack frame
             if (StackFrames.Count == 0)

Runtime/Model/JsonData/Annotations.cs

@@ -1,6 +1,5 @@
 using Backtrace.Newtonsoft;
 using Backtrace.Newtonsoft.Linq;
-using System;
 using System.Collections.Generic;
 using UnityEngine;
 using UnityEngine.SceneManagement;
@@ -45,22 +44,12 @@ public Dictionary<string, string> EnvironmentVariables
         }
 
 
-        /// <summary>
-        /// Get built-in complex attributes
-        /// </summary>
-        public Dictionary<string, object> ComplexAttributes = new Dictionary<string, object>();
-
-        public Annotations()
-        {
-        }
         /// <summary>
         /// Create new instance of Annotations class
         /// </summary>
-        /// <param name="complexAttributes">Built-in complex attributes</param>
-        public Annotations(Dictionary<string, object> complexAttributes)
+        public Annotations()
         {
             var environment = new EnvironmentVariables();
-            ComplexAttributes = complexAttributes;
             _environmentVariables = environment.Variables;
         }
 
@@ -84,12 +73,6 @@ public BacktraceJObject ToJson()
             }
             annotations[ENVIRONMENT_VARIABLE_KEY] = envVariables;
 
-            foreach (var annotation in ComplexAttributes)
-            {
-                annotations[annotation.Key] = BacktraceJObject.FromObject(annotation.Value);
-            }
-
-
             if (GameObjectDepth > -1)
             {
                 var activeScene = SceneManager.GetActiveScene();

Runtime/Model/JsonData/BacktraceAttributes.cs

@@ -22,11 +22,6 @@ public class BacktraceAttributes
 
         internal const string APPLICATION_ATTRIBUTE_NAME = "application";
 
-        /// <summary>
-        /// Get built-in complex attributes
-        /// </summary>
-        public Dictionary<string, object> ComplexAttributes = new Dictionary<string, object>();
-
         /// <summary>
         /// Create instance of Backtrace Attribute
         /// </summary>
@@ -168,20 +163,6 @@ private void ConvertAttributes(BacktraceReport report, Dictionary<string, object
                 {
                     Attributes.Add(attribute.Key, attribute.Value);
                 }
-                else
-                {
-                    ComplexAttributes.Add(attribute.Key, attribute.Value);
-                }
-            }
-            //add exception information to Complex attributes.
-            if (report.ExceptionTypeReport)
-            {
-                ComplexAttributes.Add("Exception Properties", new
-                {
-                    Type = report.Classifier,
-                    report.Message,
-                    StackTrace = report.ExceptionTypeReport ? report.Exception.StackTrace : string.Empty
-                });
             }
         }
 

Runtime/Model/JsonData/SourceCodeData.cs

@@ -24,14 +24,14 @@ public class ThreadData
         /// <summary>
         /// Create instance of ThreadData class to collect information about used threads
         /// </summary>
-        internal ThreadData(IEnumerable<BacktraceStackFrame> exceptionStack)
+        internal ThreadData(IEnumerable<BacktraceStackFrame> exceptionStack, bool faultingThread)
         {
 
             var current = Thread.CurrentThread;
             //get current thread id
             string generatedMainThreadId = current.GenerateValidThreadName().ToLower();
 
-            ThreadInformations[generatedMainThreadId] = new ThreadInformation(current, exceptionStack, true);
+            ThreadInformations[generatedMainThreadId] = new ThreadInformation(current, exceptionStack, faultingThread);
             //set currentThreadId
             MainThread = generatedMainThreadId;
         }

Runtime/Model/JsonData/SourceCodeData.cs.meta

@@ -61,11 +61,11 @@ public ThreadInformation(string threadName, bool fault, IEnumerable<BacktraceSta
         /// </summary>
         /// <param name="thread">Thread to analyse</param>
         /// <param name="stack">Exception stack information</param>
-        /// <param name="currentThread">Is current thread flag</param>
-        public ThreadInformation(Thread thread, IEnumerable<BacktraceStackFrame> stack, bool currentThread = false)
+        /// <param name="faultingThread">Faulting thread flag</param>
+        public ThreadInformation(Thread thread, IEnumerable<BacktraceStackFrame> stack, bool faultingThread = false)
             : this(
                  threadName: thread.GenerateValidThreadName().ToLower(),
-                 fault: currentThread, //faulting thread = current thread
+                 fault: faultingThread, 
                  stack: stack)
         { }