Merge pull request #194 from backtrace-labs/gm4sl/metrics-retry

gm4sl · web-flow · commit b67bbbb9b248 · 2023-11-08T16:37:57.000-05:00
metrics: retry submission on connection failure
diff --git a/Runtime/Model/Metrics/MetricsSubmissionQueue.cs b/Runtime/Model/Metrics/MetricsSubmissionQueue.cs
@@ -116,8 +116,11 @@ internal void SendPayload(ICollection<T> events, uint attempts = 0)
                 {
                     OnRequestCompleted();
                 }
-                else if (statusCode > 501 && statusCode != 505)
+                else if (httpError == true || (statusCode > 501 && statusCode != 505))
                 {
+                    // Failed to communicate with server or received a 5xx response code. Retry
+                    // again at a later time, up to the configured number of maximum attempts.
+                    //
                     _numberOfDroppedRequests++;
                     if (attempts + 1 == BacktraceMetrics.MaxNumberOfAttempts)
                     {

Original file line number	Diff line number	Diff line change
`@@ -116,8 +116,11 @@ internal void SendPayload(ICollection<T> events, uint attempts = 0)`
`116`	`116`	`{`
`117`	`117`	`OnRequestCompleted();`
`118`	`118`	`}`
`119`		`- else if (statusCode > 501 && statusCode != 505)`
	`119`	`+ else if (httpError == true \|\| (statusCode > 501 && statusCode != 505))`
`120`	`120`	`{`
	`121`	`+ // Failed to communicate with server or received a 5xx response code. Retry`
	`122`	`+ // again at a later time, up to the configured number of maximum attempts.`
	`123`	`+ //`
`121`	`124`	`_numberOfDroppedRequests++;`
`122`	`125`	`if (attempts + 1 == BacktraceMetrics.MaxNumberOfAttempts)`
`123`	`126`	`{`