Release improvements

Author: konraddysput

Runtime/Common/ClientPathHelper.cs

@@ -73,11 +73,12 @@ private static string GenerateFullPath(this string path)
         internal static bool IsFileInDatabaseDirectory(string databasePath, string filePath)
         {
             // If databasePath does not have a trailing slash, it is already a directory.
-           if (!databasePath.EndsWith("/")) {
-               return databasePath == Path.GetDirectoryName(filePath);
-           }
-           // Handles case when users put a trailing slash in their database path
-           return Path.GetDirectoryName(databasePath) == Path.GetDirectoryName(filePath);
+            if (!databasePath.EndsWith("/"))
+            {
+                return new DirectoryInfo(databasePath).FullName == new DirectoryInfo(Path.GetDirectoryName(filePath)).FullName;
+            }
+            // Handles case when users put a trailing slash in their database path
+            return Path.GetDirectoryName(databasePath) == Path.GetDirectoryName(filePath);
         }
     }
 }

Runtime/Model/Breadcrumbs/Storage/BacktraceStorageLogManager.cs

@@ -104,6 +104,10 @@ public BacktraceStorageLogManager(string storagePath)
         /// <returns>true if breadcrumbs file was created. Otherwise false.</returns>
         public bool Enable()
         {
+            if (currentSize != 0)
+            {
+                return true;
+            }
             try
             {
                 if (BreadcrumbFile.Exists())
@@ -116,6 +120,7 @@ public bool Enable()
                     _breadcrumbStream.Write(StartOfDocument, 0, StartOfDocument.Length);
                     _breadcrumbStream.Write(EndOfDocument, 0, EndOfDocument.Length);
                 }
+                _emptyFile = true;
                 currentSize = StartOfDocument.Length + EndOfDocument.Length;
             }
             catch (Exception e)
@@ -136,6 +141,11 @@ public bool Enable()
         /// <returns>True if breadcrumb was stored in the breadcrumbs file. Otherwise false.</returns>
         public bool Add(string message, BreadcrumbLevel level, UnityEngineLogLevel type, IDictionary<string, string> attributes)
         {
+            // file is not initialized 
+            if (currentSize == 0)
+            {
+                return false;
+            }
             byte[] bytes;
             lock (_lockObject)
             {

Runtime/Native/Windows/NativeClient.cs

@@ -132,7 +132,7 @@ private void HandleNativeCrashes(IDictionary<string, string> clientAttributes, I
 
             foreach (var attribute in clientAttributes)
             {
-                AddNativeAttribute(attribute.Key, attribute.Value);
+                AddNativeAttribute(attribute.Key, attribute.Value == null ? string.Empty : attribute.Value);
             }
 
             // add exception type to crashes handled by crashpad - all exception handled by crashpad