Merge pull request #17 from baldwin-agency/fix-issue-16

Adds a silly workaround to make this module work on Magento 2.4.2

Author: hostep

MagentoCoreBugFixes/FakeSelectForMagentoIssue32292.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Baldwin\UrlDataIntegrityChecker\MagentoCoreBugFixes;
+
+/**
+ * Silly workaround for core Magento bug introduced in 2.4.2
+ * - https://github.com/magento/magento2/issues/32292
+ * - https://github.com/baldwin-agency/magento2-module-url-data-integrity-checker/issues/16
+ */
+class FakeSelectForMagentoIssue32292
+{
+    /**
+     * @return array<mixed>
+     */
+    public function getPart(string $part): array
+    {
+        return [];
+    }
+}

Model/ResourceModel/Catalog/Category/UrlKeyCollection.php

@@ -5,6 +5,7 @@
 namespace Baldwin\UrlDataIntegrityChecker\Model\ResourceModel\Catalog\Category;
 
 use Baldwin\UrlDataIntegrityChecker\Checker\Catalog\Category\UrlKey as UrlKeyChecker;
+use Baldwin\UrlDataIntegrityChecker\MagentoCoreBugFixes\FakeSelectForMagentoIssue32292 as FakeSelect;
 use Baldwin\UrlDataIntegrityChecker\Storage\StorageInterface;
 use Magento\Framework\Api\AttributeInterface;
 use Magento\Framework\Api\AttributeValue;
@@ -18,14 +19,17 @@
 class UrlKeyCollection extends DataCollection implements SearchResultInterface
 {
     private $storage;
+    private $fakeSelect;
 
     public function __construct(
         EntityFactoryInterface $entityFactory,
-        StorageInterface $storage
+        StorageInterface $storage,
+        FakeSelect $fakeSelect
     ) {
         parent::__construct($entityFactory);
 
         $this->storage = $storage;
+        $this->fakeSelect = $fakeSelect;
     }
 
     /**
@@ -141,4 +145,9 @@ public function setTotalCount($totalCount)
     {
         throw new LocalizedException(__('Not implemented: setTotalCount!'));
     }
+
+    public function getSelect(): FakeSelect
+    {
+        return $this->fakeSelect;
+    }
 }

Model/ResourceModel/Catalog/Category/UrlPathCollection.php

@@ -5,6 +5,7 @@
 namespace Baldwin\UrlDataIntegrityChecker\Model\ResourceModel\Catalog\Category;
 
 use Baldwin\UrlDataIntegrityChecker\Checker\Catalog\Category\UrlPath as UrlPathChecker;
+use Baldwin\UrlDataIntegrityChecker\MagentoCoreBugFixes\FakeSelectForMagentoIssue32292 as FakeSelect;
 use Baldwin\UrlDataIntegrityChecker\Storage\StorageInterface;
 use Magento\Framework\Api\AttributeInterface;
 use Magento\Framework\Api\AttributeValue;
@@ -18,14 +19,17 @@
 class UrlPathCollection extends DataCollection implements SearchResultInterface
 {
     private $storage;
+    private $fakeSelect;
 
     public function __construct(
         EntityFactoryInterface $entityFactory,
-        StorageInterface $storage
+        StorageInterface $storage,
+        FakeSelect $fakeSelect
     ) {
         parent::__construct($entityFactory);
 
         $this->storage = $storage;
+        $this->fakeSelect = $fakeSelect;
     }
 
     /**
@@ -141,4 +145,9 @@ public function setTotalCount($totalCount)
     {
         throw new LocalizedException(__('Not implemented: setTotalCount!'));
     }
+
+    public function getSelect(): FakeSelect
+    {
+        return $this->fakeSelect;
+    }
 }

Model/ResourceModel/Catalog/Product/UrlKeyCollection.php

@@ -5,6 +5,7 @@
 namespace Baldwin\UrlDataIntegrityChecker\Model\ResourceModel\Catalog\Product;
 
 use Baldwin\UrlDataIntegrityChecker\Checker\Catalog\Product\UrlKey as UrlKeyChecker;
+use Baldwin\UrlDataIntegrityChecker\MagentoCoreBugFixes\FakeSelectForMagentoIssue32292 as FakeSelect;
 use Baldwin\UrlDataIntegrityChecker\Storage\StorageInterface;
 use Magento\Framework\Api\AttributeInterface;
 use Magento\Framework\Api\AttributeValue;
@@ -18,14 +19,17 @@
 class UrlKeyCollection extends DataCollection implements SearchResultInterface
 {
     private $storage;
+    private $fakeSelect;
 
     public function __construct(
         EntityFactoryInterface $entityFactory,
-        StorageInterface $storage
+        StorageInterface $storage,
+        FakeSelect $fakeSelect
     ) {
         parent::__construct($entityFactory);
 
         $this->storage = $storage;
+        $this->fakeSelect = $fakeSelect;
     }
 
     /**
@@ -141,4 +145,9 @@ public function setTotalCount($totalCount)
     {
         throw new LocalizedException(__('Not implemented: setTotalCount!'));
     }
+
+    public function getSelect(): FakeSelect
+    {
+        return $this->fakeSelect;
+    }
 }

Model/ResourceModel/Catalog/Product/UrlPathCollection.php

@@ -5,6 +5,7 @@
 namespace Baldwin\UrlDataIntegrityChecker\Model\ResourceModel\Catalog\Product;
 
 use Baldwin\UrlDataIntegrityChecker\Checker\Catalog\Product\UrlPath as UrlPathChecker;
+use Baldwin\UrlDataIntegrityChecker\MagentoCoreBugFixes\FakeSelectForMagentoIssue32292 as FakeSelect;
 use Baldwin\UrlDataIntegrityChecker\Storage\StorageInterface;
 use Magento\Framework\Api\AttributeInterface;
 use Magento\Framework\Api\AttributeValue;
@@ -18,14 +19,17 @@
 class UrlPathCollection extends DataCollection implements SearchResultInterface
 {
     private $storage;
+    private $fakeSelect;
 
     public function __construct(
         EntityFactoryInterface $entityFactory,
-        StorageInterface $storage
+        StorageInterface $storage,
+        FakeSelect $fakeSelect
     ) {
         parent::__construct($entityFactory);
 
         $this->storage = $storage;
+        $this->fakeSelect = $fakeSelect;
     }
 
     /**
@@ -141,4 +145,9 @@ public function setTotalCount($totalCount)
     {
         throw new LocalizedException(__('Not implemented: setTotalCount!'));
     }
+
+    public function getSelect(): FakeSelect
+    {
+        return $this->fakeSelect;
+    }
 }