fix(test): ensure we add device specs to report

Author: Almouro

packages/commands/test/src/__tests__/measurePerformance.test.ts

@@ -15,6 +15,7 @@ jest.mock("@perf-profiler/profiler", () => {
     mockPerformancePolling.setCallback(onMeasure);
     onStartMeasuring();
   });
+  mockedProfiler.detectDeviceRefreshRate = jest.fn(() => 120);
 
   return {
     ...jest.requireActual("@perf-profiler/profiler"),
@@ -90,6 +91,9 @@ describe("measurePerformance", () => {
         ],
         "name": "TITLE",
         "score": 3,
+        "specs": {
+          "refreshRate": 120,
+        },
         "status": "SUCCESS",
       }
     `);

packages/commands/test/src/__tests__/writeResults.ts

@@ -9,6 +9,7 @@ jest.mock("@perf-profiler/profiler", () => ({
   profiler: {
     ...jest.requireActual("@perf-profiler/profiler").profiler,
     installProfilerOnDevice: jest.fn(),
+    detectDeviceRefreshRate: jest.fn(() => 120),
   },
 }));
 

packages/commands/test/src/writeReport.ts

@@ -1,4 +1,5 @@
 import { Logger } from "@perf-profiler/logger";
+import { profiler } from "@perf-profiler/profiler";
 import { averageTestCaseResult } from "@perf-profiler/reporter";
 import {
   AveragedTestCaseResult,
@@ -26,6 +27,9 @@ export const writeReport = (
       measures.length === 0 || measures[measures.length - 1].status === "FAILURE"
         ? "FAILURE"
         : "SUCCESS",
+    specs: {
+      refreshRate: profiler.detectDeviceRefreshRate(),
+    },
   };
 
   /**

packages/core/types/index.ts

@@ -39,7 +39,7 @@ export interface TestCaseResult {
   status: TestCaseResultStatus;
   iterations: TestCaseIterationResult[];
   type?: TestCaseResultType;
-  specs?: DeviceSpecs;
+  specs: DeviceSpecs | undefined;
 }
 
 export interface AveragedTestCaseResult {
@@ -50,7 +50,7 @@ export interface AveragedTestCaseResult {
   average: TestCaseIterationResult;
   averageHighCpuUsage: { [processName: string]: number };
   type?: TestCaseResultType;
-  specs?: DeviceSpecs;
+  specs: DeviceSpecs | undefined;
 }
 
 // Shouldn't really be here but @perf-profiler/types is imported by everyone and doesn't contain any logic

packages/core/web-reporter-ui/ReporterView.tsx

@@ -129,6 +129,8 @@ export const ReporterView = ({ measures }: { measures: Measure[] }) => (
                 status: "SUCCESS",
               },
             ],
+            // TODO: set specs properly here
+            specs: undefined,
           },
         ]}
       />

packages/platforms/ios-instruments/src/writeReport.ts

@@ -122,6 +122,9 @@ export const writeReport = (inputFileName: string, outputFileName: string) => {
     status: "SUCCESS",
     iterations,
     type: "IOS_EXPERIMENTAL",
+    specs: {
+      refreshRate: FAKE_FPS,
+    },
   };
 
   fs.writeFileSync(outputFileName, JSON.stringify(results, null, 2));