From 7b52502aa0b59df13621d6c023521647dad0439b Mon Sep 17 00:00:00 2001 From: Ara Nguyen Date: Wed, 10 Dec 2025 15:32:57 +0000 Subject: [PATCH 1/5] add flag_alias definition for Starlarkification of python flags --- MODULE.bazel | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/MODULE.bazel b/MODULE.bazel index b909124d11..f023e5511b 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -451,3 +451,8 @@ uv_dev = use_extension( uv_dev.configure( version = "0.6.2", ) + +flag_alias("build_python_zip", "//python/config_settings:build_python_zip") +flag_alias("incompatible_default_to_explicit_init_py", "//python/config_settings:incompatible_default_to_explicit_init_py") +flag_alias("python_path", "//python/config_settings:python_path") +flag_alias("experimental_python_import_all_repositories", "//python/config_settings:experimental_python_import_all_repositories") From 5c6539e2ab4aa1e3b3dcc7e9c5a36ad6370611bf Mon Sep 17 00:00:00 2001 From: Ara Nguyen Date: Thu, 18 Dec 2025 15:30:17 +0000 Subject: [PATCH 2/5] fix error --- MODULE.bazel | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index 0f71491daf..1e9f269a11 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -459,7 +459,7 @@ uv_dev.configure( version = "0.6.2", ) -flag_alias("build_python_zip", "//python/config_settings:build_python_zip") -flag_alias("incompatible_default_to_explicit_init_py", "//python/config_settings:incompatible_default_to_explicit_init_py") -flag_alias("python_path", "//python/config_settings:python_path") -flag_alias("experimental_python_import_all_repositories", "//python/config_settings:experimental_python_import_all_repositories") +flag_alias(name = "build_python_zip", starlark_flag = "//python/config_settings:build_python_zip") +flag_alias(name = "incompatible_default_to_explicit_init_py", starlark_flag = "//python/config_settings:incompatible_default_to_explicit_init_py") +flag_alias(name = "python_path", starlark_flag = "//python/config_settings:python_path") +flag_alias(name = "experimental_python_import_all_repositories", starlark_flag = "//python/config_settings:experimental_python_import_all_repositories") From 504ccf3a74e283fe7f76b413221e40cef180ed53 Mon Sep 17 00:00:00 2001 From: Ara Nguyen Date: Thu, 18 Dec 2025 17:31:18 +0000 Subject: [PATCH 3/5] use starlark flags instead --- tests/base_rules/py_executable_base_tests.bzl | 2 +- tests/config_settings/transition/multi_version_tests.bzl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/base_rules/py_executable_base_tests.bzl b/tests/base_rules/py_executable_base_tests.bzl index ed1a55021d..45d1ffe667 100644 --- a/tests/base_rules/py_executable_base_tests.bzl +++ b/tests/base_rules/py_executable_base_tests.bzl @@ -93,7 +93,7 @@ def _test_basic_zip(name, config): # platforms. # Pass value to both native and starlark versions of the flag until # the native one is removed. - "//command_line_option:build_python_zip": "true", + "@@//python/config_settings:build_python_zip": "true", labels.BUILD_PYTHON_ZIP: True, "//command_line_option:cpu": "linux_x86_64", "//command_line_option:crosstool_top": CROSSTOOL_TOP, diff --git a/tests/config_settings/transition/multi_version_tests.bzl b/tests/config_settings/transition/multi_version_tests.bzl index 05f010562c..f0864d8bf0 100644 --- a/tests/config_settings/transition/multi_version_tests.bzl +++ b/tests/config_settings/transition/multi_version_tests.bzl @@ -92,7 +92,7 @@ def _setup_py_binary_windows(name, *, impl, build_python_zip): target = name + "_subject", impl = impl, config_settings = { - "//command_line_option:build_python_zip": str(build_python_zip), + "@@//python/config_settings:build_python_zip": str(build_python_zip), labels.BUILD_PYTHON_ZIP: build_python_zip, "//command_line_option:extra_toolchains": CC_TOOLCHAIN, "//command_line_option:platforms": str(platform_targets.WINDOWS_X86_64), From effbe4cd6c4428cdb7c15bf8d645a5e97a89b9f1 Mon Sep 17 00:00:00 2001 From: Ara Nguyen Date: Thu, 18 Dec 2025 18:05:51 +0000 Subject: [PATCH 4/5] fix starlark label --- tests/base_rules/py_executable_base_tests.bzl | 2 +- tests/config_settings/transition/multi_version_tests.bzl | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/base_rules/py_executable_base_tests.bzl b/tests/base_rules/py_executable_base_tests.bzl index 45d1ffe667..a946bf7e89 100644 --- a/tests/base_rules/py_executable_base_tests.bzl +++ b/tests/base_rules/py_executable_base_tests.bzl @@ -93,7 +93,7 @@ def _test_basic_zip(name, config): # platforms. # Pass value to both native and starlark versions of the flag until # the native one is removed. - "@@//python/config_settings:build_python_zip": "true", + "//python/config_settings:build_python_zip": "true", labels.BUILD_PYTHON_ZIP: True, "//command_line_option:cpu": "linux_x86_64", "//command_line_option:crosstool_top": CROSSTOOL_TOP, diff --git a/tests/config_settings/transition/multi_version_tests.bzl b/tests/config_settings/transition/multi_version_tests.bzl index f0864d8bf0..e025abbb4c 100644 --- a/tests/config_settings/transition/multi_version_tests.bzl +++ b/tests/config_settings/transition/multi_version_tests.bzl @@ -85,14 +85,14 @@ def _setup_py_binary_windows(name, *, impl, build_python_zip): name = name + "_subject", srcs = [name + "_subject.py"], python_version = _PYTHON_VERSION, - ) +i ) analysis_test( name = name, target = name + "_subject", impl = impl, config_settings = { - "@@//python/config_settings:build_python_zip": str(build_python_zip), + "//python/config_settings:build_python_zip": str(build_python_zip), labels.BUILD_PYTHON_ZIP: build_python_zip, "//command_line_option:extra_toolchains": CC_TOOLCHAIN, "//command_line_option:platforms": str(platform_targets.WINDOWS_X86_64), From e7bc46429872213408dae77a217ed33051dd03da Mon Sep 17 00:00:00 2001 From: Ara Nguyen Date: Thu, 18 Dec 2025 18:22:02 +0000 Subject: [PATCH 5/5] remove extra character --- tests/config_settings/transition/multi_version_tests.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/config_settings/transition/multi_version_tests.bzl b/tests/config_settings/transition/multi_version_tests.bzl index e025abbb4c..b9b8a6b482 100644 --- a/tests/config_settings/transition/multi_version_tests.bzl +++ b/tests/config_settings/transition/multi_version_tests.bzl @@ -85,7 +85,7 @@ def _setup_py_binary_windows(name, *, impl, build_python_zip): name = name + "_subject", srcs = [name + "_subject.py"], python_version = _PYTHON_VERSION, -i ) + ) analysis_test( name = name,