Add openconfig_attestz@0.6.0 #6217
Conversation
|
@bazel-io skip_check unstable_url |
|
Hello @marcushines, modules you maintain (openconfig_attestz) have been updated in this PR. |
bazel-io
added
the
skip-url-stability-check
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR adds version 0.6.0 of openconfig_attestz. My review found a critical issue with the provided patch file, which attempts to modify a MODULE.bazel file that does not exist in the source archive, which would cause presubmit to fail. I have provided a corrected patch that creates the file instead. Additionally, I've identified an unused grpc dependency in the MODULE.bazel file that should be removed to simplify the dependency graph for consumers.
| --- MODULE.bazel | ||
| +++ MODULE.bazel | ||
| @@ -1,6 +1,6 @@ | ||
| module( | ||
| name = "openconfig_attestz", | ||
| - version = "0.0.0", | ||
| + version = "0.6.0", | ||
| ) | ||
|
|
||
| bazel_dep(name = "gazelle", version = "0.45.0", repo_name = "bazel_gazelle") |
There was a problem hiding this comment.
This patch attempts to modify a MODULE.bazel file, but this file does not exist in the upstream source archive for tag v0.6.0. This will cause the patch to fail during presubmit checks. The patch should instead be written to create the MODULE.bazel file.
I have also taken the liberty of removing the seemingly unused bazel_dep on grpc from the suggested patch content below.
--- /dev/null
+++ MODULE.bazel
@@ -0,0 +1,16 @@
+module(
+ name = "openconfig_attestz",
+ version = "0.6.0",
+)
+
+bazel_dep(name = "gazelle", version = "0.45.0", repo_name = "bazel_gazelle")
+bazel_dep(name = "protobuf", version = "32.1", repo_name = "com_google_protobuf")
+bazel_dep(name = "rules_go", version = "0.57.0", repo_name = "io_bazel_rules_go")
+bazel_dep(name = "rules_proto", version = "7.1.0")
+
+go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk")
+go_sdk.download(version = "1.25.1")
+
+go_deps = use_extension("@bazel_gazelle//:extensions.bzl", "go_deps")
+go_deps.from_file(go_mod = "//:go.mod")
+use_repo(go_deps, "com_github_golang_glog", "com_github_google_go_cmp", "org_golang_google_grpc", "org_golang_google_grpc_cmd_protoc_gen_go_grpc", "org_golang_google_protobuf", "com_github_google_go_tpm")
| ) | ||
|
|
||
| bazel_dep(name = "gazelle", version = "0.45.0", repo_name = "bazel_gazelle") | ||
| bazel_dep(name = "grpc", version = "1.74.1", repo_name = "com_github_grpc_grpc") |
There was a problem hiding this comment.
This bazel_dep on grpc (the C++ library) appears to be unused for this Go module. The necessary Go gRPC dependencies are fetched via go_deps from go.mod, and rules_go utilizes the Go gRPC protoc plugin from those dependencies. Removing this unused dependency will simplify the dependency graph for consumers of this module.
bazel-io
dismissed
their stale review
Require module maintainers' approval for newly pushed changes.
|
@bazel-io skip_check incompatible_flags |
bazel-io
added
the
skip-incompatible-flags-test
|
I am not sure why the earlier CI run failed: the |
bazel-io
dismissed
their stale review
Require module maintainers' approval for newly pushed changes.
|
@bazelbuild/bcr-maintainers can the presubmit.yml change be approved to run CI? |
Wyverald
added
the
presubmit-auto-run
bazel-io
added
the
auto-merged
3 participants
Add openconfig_attestz@0.6.0