Skip to content

Commit 8e80298

Browse files
committed
Everything all at once
1 parent c789c9f commit 8e80298

File tree

33 files changed

+190
-163
lines changed

33 files changed

+190
-163
lines changed

src/backend/efiling-api/src/main/java/ca/bc/gov/open/jag/efilingapi/Keys.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,6 @@ protected Keys() {}
3232

3333
public static final String REJECTED_DOCUMENT_CODE = "REJ";
3434

35+
public static final String DEFAULT_DIVISION = "I";
36+
3537
}

src/backend/efiling-api/src/main/java/ca/bc/gov/open/jag/efilingapi/document/DocumentServiceImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package ca.bc.gov.open.jag.efilingapi.document;
22

3+
import ca.bc.gov.open.jag.efilingapi.Keys;
34
import ca.bc.gov.open.jag.efilingapi.document.models.GetValidDocumentTypesRequest;
45
import ca.bc.gov.open.jag.efilingcommons.model.DocumentTypeDetails;
56
import ca.bc.gov.open.jag.efilingcommons.service.EfilingDocumentService;
@@ -16,7 +17,7 @@ public DocumentServiceImpl(EfilingDocumentService efilingDocumentService) {
1617

1718
@Override
1819
public List<DocumentTypeDetails> getValidDocumentTypes(GetValidDocumentTypesRequest getValidDocumentTypesRequest) {
19-
return efilingDocumentService.getDocumentTypes(getValidDocumentTypesRequest.getCourtLevel(), getValidDocumentTypesRequest.getCourtClassification());
20+
return efilingDocumentService.getDocumentTypes(getValidDocumentTypesRequest.getCourtLevel(), getValidDocumentTypesRequest.getCourtClassification(), Keys.DEFAULT_DIVISION);
2021
}
2122

2223
}

src/backend/efiling-api/src/main/java/ca/bc/gov/open/jag/efilingapi/document/DocumentStoreImpl.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package ca.bc.gov.open.jag.efilingapi.document;
22

3+
import ca.bc.gov.open.jag.efilingapi.Keys;
34
import ca.bc.gov.open.jag.efilingapi.submission.SubmissionKey;
45
import ca.bc.gov.open.jag.efilingcommons.model.DocumentTypeDetails;
56
import ca.bc.gov.open.jag.efilingcommons.service.EfilingDocumentService;
@@ -38,12 +39,12 @@ public void evict(SubmissionKey submissionKey, String fileName) {
3839
@Override
3940
@Cacheable(cacheNames = "documentDetails", cacheManager = "documentTypeDetailsCacheManager", unless = "#result == null")
4041
public DocumentTypeDetails getDocumentDetails(String courtLevel, String courtClass, String documentType) {
41-
return this.efilingDocumentService.getDocumentTypeDetails(courtLevel, courtClass, documentType);
42+
return this.efilingDocumentService.getDocumentTypeDetails(courtLevel, courtClass, documentType, Keys.DEFAULT_DIVISION);
4243
}
4344

4445
@Override
4546
public List<DocumentTypeDetails> getDocumentTypes(String courtLevel, String courtClass) {
46-
return this.efilingDocumentService.getDocumentTypes(courtLevel, courtClass);
47+
return this.efilingDocumentService.getDocumentTypes(courtLevel, courtClass, Keys.DEFAULT_DIVISION);
4748
}
4849

4950
@Override

src/backend/efiling-api/src/main/java/ca/bc/gov/open/jag/efilingapi/filingpackage/service/FilingPackageServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public Optional<FilingPackage> getCSOFilingPackage(String universalId, BigDecima
6666
if (!filingPackage.isPresent()) return Optional.empty();
6767

6868
filingPackage.get().getDocuments().forEach(
69-
reviewDocument -> reviewDocument.setRushRequired(efilingDocumentService.getDocumentTypeDetails(filingPackage.get().getCourt().getLevel(),filingPackage.get().getCourt().getCourtClass(), reviewDocument.getDocumentTypeCd()).isRushRequired())
69+
reviewDocument -> reviewDocument.setRushRequired(efilingDocumentService.getDocumentTypeDetails(filingPackage.get().getCourt().getLevel(),filingPackage.get().getCourt().getCourtClass(), reviewDocument.getDocumentTypeCd(), Keys.DEFAULT_DIVISION).isRushRequired())
7070
);
7171

7272
return filingPackage.map(filingPackageMapper::toResponseFilingPackage);

src/backend/efiling-api/src/main/java/ca/bc/gov/open/jag/efilingapi/submission/models/GetValidPartyRoleRequest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ public class GetValidPartyRoleRequest {
1313
private String courtLevel;
1414
private String courtClassification;
1515

16+
private String division;
17+
1618
public List<InitialDocument> getInitialDocuments() {
1719
return initialDocuments;
1820
}
@@ -25,13 +27,18 @@ public String getCourtClassification() {
2527
return courtClassification;
2628
}
2729

30+
public String getDivision() {
31+
return division;
32+
}
33+
2834
public String getDocumentTypesAsString() {
2935
return this.initialDocuments.stream().map(InitialDocument::getType).collect(Collectors.joining(","));
3036
}
3137

3238
public GetValidPartyRoleRequest(Builder builder) {
3339
this.initialDocuments = builder.documents;
3440
this.courtLevel = builder.courtLevel;
41+
this.division = builder.division;
3542
this.courtClassification = builder.courtClassification;
3643
}
3744

@@ -46,6 +53,7 @@ public GetValidPartyRoleRequest create() {
4653
}
4754

4855
private String courtLevel;
56+
private String division;
4957

5058
public Builder courtLevel(String courtLevel) {
5159
this.courtLevel = courtLevel;
@@ -59,6 +67,11 @@ public Builder courtClassification(String courtClassification) {
5967
return this;
6068
}
6169

70+
public Builder division(String division) {
71+
this.division = division;
72+
return this;
73+
}
74+
6275
private List<InitialDocument> documents;
6376

6477
public Builder documents(List<InitialDocument> documents) {

src/backend/efiling-api/src/main/java/ca/bc/gov/open/jag/efilingapi/submission/service/SubmissionServiceImpl.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package ca.bc.gov.open.jag.efilingapi.submission.service;
22

3+
import ca.bc.gov.open.jag.efilingapi.Keys;
34
import ca.bc.gov.open.jag.efilingapi.api.model.*;
45
import ca.bc.gov.open.jag.efilingapi.config.NavigationProperties;
56
import ca.bc.gov.open.jag.efilingapi.document.DocumentStore;
@@ -170,15 +171,16 @@ public List<String> getValidPartyRoles(GetValidPartyRoleRequest getValidPartyRol
170171
return efilingLookupService.getValidPartyRoles(
171172
getValidPartyRoleRequest.getCourtLevel(),
172173
getValidPartyRoleRequest.getCourtClassification(),
173-
getValidPartyRoleRequest.getDocumentTypesAsString()
174+
getValidPartyRoleRequest.getDocumentTypesAsString(),
175+
getValidPartyRoleRequest.getDivision()
174176
);
175177

176178
}
177179

178180
@Override
179181
public Boolean isRushRequired(String documentType, String courtLevel, String courtClass) {
180182

181-
DocumentTypeDetails documentTypeDetails = efilingDocumentService.getDocumentTypeDetails(courtLevel, courtClass, documentType);
183+
DocumentTypeDetails documentTypeDetails = efilingDocumentService.getDocumentTypeDetails(courtLevel, courtClass, documentType, Keys.DEFAULT_DIVISION);
182184

183185
return documentTypeDetails.isRushRequired();
184186

src/backend/efiling-api/src/main/java/ca/bc/gov/open/jag/efilingapi/submission/validator/GenerateUrlRequestValidatorImpl.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package ca.bc.gov.open.jag.efilingapi.submission.validator;
22

3+
import ca.bc.gov.open.jag.efilingapi.Keys;
34
import ca.bc.gov.open.jag.efilingapi.api.model.*;
45
import ca.bc.gov.open.jag.efilingapi.court.models.GetCourtDetailsRequest;
56
import ca.bc.gov.open.jag.efilingapi.court.models.IsValidCourtFileNumberRequest;
@@ -142,6 +143,7 @@ private List<String> validateParties(InitialPackage initialPackage) {
142143
.courtClassification(initialPackage.getCourt().getCourtClass())
143144
.courtLevel(initialPackage.getCourt().getLevel())
144145
.documents(initialPackage.getDocuments())
146+
.division(Keys.DEFAULT_DIVISION)
145147
.create());
146148

147149
List<String> validationResult = new ArrayList<>();

src/backend/efiling-api/src/test/java/ca/bc/gov/open/jag/efilingapi/document/DocumentServiceImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public void beforeAll() {
3131
List<DocumentTypeDetails> documentList = new ArrayList<>();
3232
DocumentTypeDetails document = new DocumentTypeDetails("description", "type", BigDecimal.TEN,false, true, true);
3333
documentList.add(document);
34-
Mockito.when(efilingDocumentServiceMock.getDocumentTypes(Mockito.eq(COURT_LEVEL), Mockito.eq(COURT_CLASSIFICATION))).thenReturn(documentList);
34+
Mockito.when(efilingDocumentServiceMock.getDocumentTypes(Mockito.eq(COURT_LEVEL), Mockito.eq(COURT_CLASSIFICATION), Mockito.any())).thenReturn(documentList);
3535

3636
sut = new DocumentServiceImpl(efilingDocumentServiceMock);
3737

src/backend/efiling-api/src/test/java/ca/bc/gov/open/jag/efilingapi/document/DocumentStoreImplTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ public void setUp() {
3232
DocumentTypeDetails docummentDetails = new DocumentTypeDetails(DESCRIPTION, TYPE, BigDecimal.TEN, true, true, true);
3333

3434
Mockito
35-
.when(efilingDocumentServiceMock.getDocumentTypeDetails(Mockito.anyString(), Mockito.anyString(), Mockito.anyString()))
35+
.when(efilingDocumentServiceMock.getDocumentTypeDetails(Mockito.anyString(), Mockito.anyString(), Mockito.anyString(), Mockito.any()))
3636
.thenReturn(docummentDetails);
3737

3838

3939
List<DocumentTypeDetails> documentTypeDetails = Arrays.asList(new DocumentTypeDetails(DESCRIPTION, TYPE, BigDecimal.TEN, true, true, true));
4040

4141
Mockito
42-
.when(efilingDocumentServiceMock.getDocumentTypes(Mockito.anyString(), Mockito.anyString()))
42+
.when(efilingDocumentServiceMock.getDocumentTypes(Mockito.anyString(), Mockito.anyString(), Mockito.any()))
4343
.thenReturn(documentTypeDetails);
4444

4545
sut = new DocumentStoreImpl(efilingDocumentServiceMock);

src/backend/efiling-api/src/test/java/ca/bc/gov/open/jag/efilingapi/fakes/EfilingDocumentServiceFake.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77

88
public class EfilingDocumentServiceFake implements EfilingDocumentService {
99
@Override
10-
public DocumentTypeDetails getDocumentTypeDetails(String courtLevel, String courtClass, String documentType) {
10+
public DocumentTypeDetails getDocumentTypeDetails(String courtLevel, String courtClass, String documentType, String division) {
1111
return null;
1212
}
1313

1414
@Override
15-
public List<DocumentTypeDetails> getDocumentTypes(String courtLevel, String courtClass) {
15+
public List<DocumentTypeDetails> getDocumentTypes(String courtLevel, String courtClass, String division) {
1616
return null;
1717
}
1818
}

0 commit comments

Comments
 (0)