fixing Scrutinizer issues

Author: bdelespierre

src/Euclidean/Point.php

@@ -56,7 +56,7 @@ private function sanitizeCoordinates(array $coordinates): array
         assert(is_array($coordinates));
         $errors = array_keys($coordinates, false, true);
 
-        if ($errors) {
+        if (! empty($errors)) {
             throw new \InvalidArgumentException(sprintf(
                 "Invalid set of coordinates: values at offsets [%s] could not be converted to numbers",
                 implode(',', $errors)

src/Gps/Point.php

@@ -6,9 +6,6 @@
 use Kmeans\Concerns\HasSpaceTrait;
 use Kmeans\Interfaces\PointInterface;
 
-/**
- * @method array{0: float, 1: float} getCoordinates()
- */
 class Point implements PointInterface
 {
     use HasDataTrait;

src/Math.php

@@ -12,7 +12,7 @@ public static function euclideanDist(array $a, array $b): float
     {
         assert(count($a) == count($b));
 
-        for ($dist = 0, $n = 0; $n < count($a); $n++) {
+        for ($dist = 0, $n = 0, $c = count($a); $n < $c; $n++) {
             $dist += pow($a[$n] - $b[$n], 2);
         }
 
@@ -46,7 +46,7 @@ public static function centroid(array $points): array
      *
      * @see https://en.wikipedia.org/wiki/Box%E2%80%93Muller_transform
      *
-     * @return array{float, float}
+     * @return array{0: float, 1: float}
      */
     public static function gaussianNoise(float $mu, float $sigma): array
     {

src/RandomInitialization.php

@@ -36,14 +36,7 @@ protected function getRandomPoint(PointCollectionInterface $points): PointInterf
             throw new \LogicException("Unable to pick a random point out of an empty point collection");
         }
 
-        $num = mt_rand(0, count($points) - 1);
-        foreach ($points as $i => $point) {
-            if ($i > $num) {
-                break;
-            }
-        }
-
-        assert(isset($point));
-        return $point;
+        $arr = iterator_to_array($points);
+        return $arr[array_rand($arr)];
     }
 }