Fix error if calling resume method when carousel is already playing (#57)

ed-sa-ma · web-flow · commit 37cb1b6437c8 · 2021-04-03T01:07:21.000+01:00
* Avoid adding intervals when there is one already

* Update built files
diff --git a/dist/index.js b/dist/index.js
@@ -693,6 +693,7 @@
 
     		return () => {
     			autoplay && clearInterval(timer);
+    			timer = null;
     			controller.destroy();
     		}
     	});
@@ -716,10 +717,11 @@
     	
     	function pause() {
     		clearInterval(timer);
+    		timer = null;
     	}
 
     	function resume() {
-    		if (autoplay) {
+    		if (autoplay && !timer) {
     			timer = setInterval(right, autoplay);
     		}
     	}
diff --git a/dist/index.mjs b/dist/index.mjs
@@ -687,6 +687,7 @@ function instance($$self, $$props, $$invalidate) {
 
 		return () => {
 			autoplay && clearInterval(timer);
+			timer = null;
 			controller.destroy();
 		}
 	});
@@ -710,10 +711,11 @@ function instance($$self, $$props, $$invalidate) {
 	
 	function pause() {
 		clearInterval(timer);
+		timer = null;
 	}
 
 	function resume() {
-		if (autoplay) {
+		if (autoplay && !timer) {
 			timer = setInterval(right, autoplay);
 		}
 	}
diff --git a/src/Carousel.svelte b/src/Carousel.svelte
@@ -127,6 +127,7 @@
 
 		return () => {
 			autoplay && clearInterval(timer)
+			timer = null
 			controller.destroy()
 		}
 	})
@@ -150,10 +151,11 @@
 	
 	export function pause() {
 		clearInterval(timer);
+		timer = null
 	}
 
 	export function resume() {
-		if (autoplay) {
+		if (autoplay && !timer) {
 			timer = setInterval(right, autoplay);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -693,6 +693,7 @@`
`693`	`693`
`694`	`694`	`return () => {`
`695`	`695`	`autoplay && clearInterval(timer);`
	`696`	`+ timer = null;`
`696`	`697`	`controller.destroy();`
`697`	`698`	`}`
`698`	`699`	`});`
`@@ -716,10 +717,11 @@`
`716`	`717`
`717`	`718`	`function pause() {`
`718`	`719`	`clearInterval(timer);`
	`720`	`+ timer = null;`
`719`	`721`	`}`
`720`	`722`
`721`	`723`	`function resume() {`
`722`		`- if (autoplay) {`
	`724`	`+ if (autoplay && !timer) {`
`723`	`725`	`timer = setInterval(right, autoplay);`
`724`	`726`	`}`
`725`	`727`	`}`
Original file line number	Diff line number	Diff line change
`@@ -687,6 +687,7 @@ function instance($$self, $$props, $$invalidate) {`
`687`	`687`
`688`	`688`	`return () => {`
`689`	`689`	`autoplay && clearInterval(timer);`
	`690`	`+ timer = null;`
`690`	`691`	`controller.destroy();`
`691`	`692`	`}`
`692`	`693`	`});`
`@@ -710,10 +711,11 @@ function instance($$self, $$props, $$invalidate) {`
`710`	`711`
`711`	`712`	`function pause() {`
`712`	`713`	`clearInterval(timer);`
	`714`	`+ timer = null;`
`713`	`715`	`}`
`714`	`716`
`715`	`717`	`function resume() {`
`716`		`- if (autoplay) {`
	`718`	`+ if (autoplay && !timer) {`
`717`	`719`	`timer = setInterval(right, autoplay);`
`718`	`720`	`}`
`719`	`721`	`}`
Original file line number	Diff line number	Diff line change
`@@ -127,6 +127,7 @@`
`127`	`127`
`128`	`128`	`return () => {`
`129`	`129`	`autoplay && clearInterval(timer)`
	`130`	`+ timer = null`
`130`	`131`	`controller.destroy()`
`131`	`132`	`}`
`132`	`133`	`})`
`@@ -150,10 +151,11 @@`
`150`	`151`
`151`	`152`	`export function pause() {`
`152`	`153`	`clearInterval(timer);`
	`154`	`+ timer = null`
`153`	`155`	`}`
`154`	`156`
`155`	`157`	`export function resume() {`
`156`		`- if (autoplay) {`
	`158`	`+ if (autoplay && !timer) {`
`157`	`159`	`timer = setInterval(right, autoplay);`
`158`	`160`	`}`
`159`	`161`	`}`