DoOrDelay Utility function

[jmarren]

There are several occurrences of this particular functionality, so I'd like to propose adding the following utility function.

If you do a search for getWindow().setTimeout you will see that this function is appropriate for the majority of cases that window.setTimeout is used.

It is fairly self-explanatory:

/**
   * @param {number} delay
   * @param {function} callback
   * @param {function} elseCallback (optional)
   * @returns { any }
   */
  function doOrDelay(callback, delay, elseCallback) {
    if (delay && delay > 0) {
      return getWindow().setTimeout(callback, delay);
    } else if (elseCallback) {
      return elseCallback();
    } else {
      return callback();
    }
  }

[MichaelWest22]

actually I don't think the more complicated elseCallback would be required and it could just be

   /**
   * @param {function} callback
   * @param {number} [delay]
   */
  function maybeDelay(callback, delay) {
    if (delay && delay > 0) {
      getWindow().setTimeout(callback, delay)
    } else {
      callback()
    }
  }

All the cases where there is an alternative else block could be re-written to work as a single callback function. Also it is not valid to return a return value from setTimeout as this just returns the id number of the timeout and not the function response. We never use the return value anyway so not an issue.

[MichaelWest22]

master...MichaelWest22:maybedelay something like this maybe

[jmarren]

That looks perfect