Fix ChainPosition ordering
#2074
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes incorrect ordering of
ChainPositionthat affected how wallet transactions are displayed. Previously, unconfirmed transactions that were never seen in the mempool would incorrectly appear before transactions with mempool timestamps due to the derivedOrdimplementation treatingNoneas less thanSome(_).Problem
The derived
Ordimplementation forChainPosition::Unconfirmedcaused incorrect transaction ordering:Unconfirmed { first_seen: None, last_seen: None }(never in mempool)Unconfirmed { first_seen: Some(10), last_seen: Some(10) }(seen in mempool)This resulted in a confusing wallet display where transactions never broadcast would appear before pending mempool transactions.
Solution
Implemented manual
OrdandPartialOrdtraits forChainPositionwith the correct ordering:first_seen)Additional ordering rules:
Changelog notice
Fixed
ChainPositionordering so unconfirmed transactions never seen in mempool appear last instead of firstChanged
ChainPosition,CanonicalTx, andFullTxOutnow requireA: Ordfor theirOrdimplementationsFullTxOutordering to only use essential fields (chain_position, outpoint, spent_by)Checklists
All Submissions:
Bugfixes: