fix(database): log pool errors vs throwing an error (#979)

Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>

Author: wolf31o2

database/plugin/metadata/sqlite/pool.go

@@ -149,9 +149,7 @@ func (d *MetadataStoreSqlite) SetPoolRegistration(
 	}
 	tmpPool, err := d.GetPool(cert.Operator[:], txn)
 	if err != nil {
-		if errors.Is(err, models.ErrPoolNotFound) {
-			// Do nothing :-)
-		} else {
+		if !errors.Is(err, models.ErrPoolNotFound) {
 			return err
 		}
 	}
@@ -202,11 +200,11 @@ func (d *MetadataStoreSqlite) SetPoolRegistration(
 	}
 	tmpPool.Registration = append(tmpPool.Registration, tmpReg)
 	tmpPool.Relays = tmpReg.Relays
-	onConflict := clause.OnConflict{
+	// d.logger.Debug("pool registration", "hash", tmpReg.PoolKeyHash)
+	result := txn.Clauses(clause.OnConflict{
 		Columns:   []clause.Column{{Name: "pool_key_hash"}},
 		UpdateAll: true,
-	}
-	result := txn.Clauses(onConflict).Create(&tmpPool)
+	}).Create(&tmpPool)
 	if result.Error != nil {
 		return result.Error
 	}
@@ -227,7 +225,9 @@ func (d *MetadataStoreSqlite) SetPoolRetirement(
 		return err
 	}
 	if tmpPool == nil {
-		return models.ErrPoolNotFound
+		d.logger.Warn("retiring non-existent pool", "hash", cert.PoolKeyHash)
+		tmpPool = &models.Pool{PoolKeyHash: cert.PoolKeyHash[:]}
+		// return models.ErrPoolNotFound
 	}
 	tmpItem := models.PoolRetirement{
 		PoolKeyHash: cert.PoolKeyHash[:],

ledger/view.go

@@ -15,9 +15,11 @@
 package ledger
 
 import (
+	"errors"
 	"time"
 
 	"github.com/blinklabs-io/dingo/database"
+	"github.com/blinklabs-io/dingo/database/models"
 	"github.com/blinklabs-io/gouroboros/cbor"
 	lcommon "github.com/blinklabs-io/gouroboros/ledger/common"
 )
@@ -82,7 +84,11 @@ func (lv *LedgerView) PoolCurrentState(
 ) (*lcommon.PoolRegistrationCertificate, *uint64, error) {
 	pool, err := lv.ls.db.GetPool(pkh, lv.txn)
 	if err != nil {
-		return nil, nil, err
+		if errors.Is(err, models.ErrPoolNotFound) {
+			pool = &models.Pool{}
+		} else {
+			return nil, nil, err
+		}
 	}
 	var currentReg *lcommon.PoolRegistrationCertificate
 	if len(pool.Registration) > 0 {