Skip to content

Commit 8194f2a

Browse files
committed
feat(ledger):Addressed all the comments and made corresponding changes
Signed-off-by: Akhil Repala <arepala@blinklabs.io>
1 parent 8f01d63 commit 8194f2a

File tree

10 files changed

+363
-261
lines changed

10 files changed

+363
-261
lines changed

ledger/allegra/allegra.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ type AllegraBlock struct {
4949
BlockHeader *AllegraBlockHeader
5050
TransactionBodies []AllegraTransactionBody
5151
TransactionWitnessSets []shelley.ShelleyTransactionWitnessSet
52-
TransactionMetadataSet map[uint]common.TransactionMetadataSet
52+
TransactionMetadataSet common.TransactionMetadataSet
5353
}
5454

5555
func (b *AllegraBlock) UnmarshalCBOR(cborData []byte) error {
@@ -239,7 +239,7 @@ type AllegraTransaction struct {
239239
hash *common.Blake2b256
240240
Body AllegraTransactionBody
241241
WitnessSet shelley.ShelleyTransactionWitnessSet
242-
TxMetadata common.TransactionMetadataSet
242+
TxMetadata common.TransactionMetadatum
243243
}
244244

245245
func (t *AllegraTransaction) UnmarshalCBOR(cborData []byte) error {
@@ -349,7 +349,7 @@ func (t AllegraTransaction) Donation() uint64 {
349349
return t.Body.Donation()
350350
}
351351

352-
func (t AllegraTransaction) Metadata() common.TransactionMetadataSet {
352+
func (t AllegraTransaction) Metadata() common.TransactionMetadatum {
353353
return t.TxMetadata
354354
}
355355

ledger/alonzo/alonzo.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ type AlonzoBlock struct {
5555
BlockHeader *AlonzoBlockHeader
5656
TransactionBodies []AlonzoTransactionBody
5757
TransactionWitnessSets []AlonzoTransactionWitnessSet
58-
TransactionMetadataSet map[uint]common.TransactionMetadataSet
58+
TransactionMetadataSet common.TransactionMetadataSet
5959
InvalidTransactions []uint
6060
}
6161

@@ -591,7 +591,7 @@ type AlonzoTransaction struct {
591591
Body AlonzoTransactionBody
592592
WitnessSet AlonzoTransactionWitnessSet
593593
TxIsValid bool
594-
TxMetadata common.TransactionMetadataSet
594+
TxMetadata common.TransactionMetadatum
595595
}
596596

597597
func (t *AlonzoTransaction) UnmarshalCBOR(cborData []byte) error {
@@ -705,7 +705,7 @@ func (t AlonzoTransaction) Donation() uint64 {
705705
return t.Body.Donation()
706706
}
707707

708-
func (t AlonzoTransaction) Metadata() common.TransactionMetadataSet {
708+
func (t AlonzoTransaction) Metadata() common.TransactionMetadatum {
709709
return t.TxMetadata
710710
}
711711

ledger/babbage/babbage.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ type BabbageBlock struct {
5555
BlockHeader *BabbageBlockHeader
5656
TransactionBodies []BabbageTransactionBody
5757
TransactionWitnessSets []BabbageTransactionWitnessSet
58-
TransactionMetadataSet map[uint]common.TransactionMetadataSet
58+
TransactionMetadataSet common.TransactionMetadataSet
5959
InvalidTransactions []uint
6060
}
6161

@@ -733,7 +733,7 @@ type BabbageTransaction struct {
733733
Body BabbageTransactionBody
734734
WitnessSet BabbageTransactionWitnessSet
735735
TxIsValid bool
736-
TxMetadata common.TransactionMetadataSet
736+
TxMetadata common.TransactionMetadatum
737737
}
738738

739739
func (t *BabbageTransaction) UnmarshalCBOR(cborData []byte) error {
@@ -847,7 +847,7 @@ func (t BabbageTransaction) Donation() uint64 {
847847
return t.Body.Donation()
848848
}
849849

850-
func (t BabbageTransaction) Metadata() common.TransactionMetadataSet {
850+
func (t BabbageTransaction) Metadata() common.TransactionMetadatum {
851851
return t.TxMetadata
852852
}
853853

ledger/byron/byron.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ type ByronTransaction struct {
142142
hash *common.Blake2b256
143143
TxInputs []ByronTransactionInput
144144
TxOutputs []ByronTransactionOutput
145-
Attributes common.TransactionMetadataSet
145+
Attributes common.TransactionMetadatum
146146
}
147147

148148
func (t *ByronTransaction) UnmarshalCBOR(cborData []byte) error {
@@ -275,7 +275,7 @@ func (t *ByronTransaction) Donation() uint64 {
275275
return 0
276276
}
277277

278-
func (t *ByronTransaction) Metadata() common.TransactionMetadataSet {
278+
func (t *ByronTransaction) Metadata() common.TransactionMetadatum {
279279
return t.Attributes
280280
}
281281

0 commit comments

Comments
 (0)