kprobes/x86: Use copy_from_kernel_nofault() to read from unsafe address

jira LE-1907
cve CVE-2024-26946
Rebuild_History Non-Buildable kernel-5.14.0-427.35.1.el9_4
commit-author Masami Hiramatsu (Google) <mhiramat@kernel.org>
commit 4e51653

Read from an unsafe address with copy_from_kernel_nofault() in
arch_adjust_kprobe_addr() because this function is used before checking
the address is in text or not. Syzcaller bot found a bug and reported
the case if user specifies inaccessible data area,
arch_adjust_kprobe_addr() will cause a kernel panic.

[ mingo: Clarified the comment. ]

Fixes: cc66bb9 ("x86/ibt,kprobes: Cure sym+0 equals fentry woes")
	Reported-by: Qiang Zhang <zzqq0103.hey@gmail.com>
	Tested-by: Jinghao Jia <jinghao7@illinois.edu>
	Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
	Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/171042945004.154897.2221804961882915806.stgit@devnote2
(cherry picked from commit 4e51653)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>

Author: PlaidCat

arch/x86/kernel/kprobes/core.c

@@ -303,7 +303,16 @@ static int can_probe(unsigned long paddr)
 kprobe_opcode_t *arch_adjust_kprobe_addr(unsigned long addr, unsigned long offset,
 					 bool *on_func_entry)
 {
-	if (is_endbr(*(u32 *)addr)) {
+	u32 insn;
+
+	/*
+	 * Since 'addr' is not guaranteed to be safe to access, use
+	 * copy_from_kernel_nofault() to read the instruction:
+	 */
+	if (copy_from_kernel_nofault(&insn, (void *)addr, sizeof(u32)))
+		return NULL;
+
+	if (is_endbr(insn)) {
 		*on_func_entry = !offset || offset == 4;
 		if (*on_func_entry)
 			offset = 4;