Skip to content

Conversation

@43081j
Copy link
Collaborator

@43081j 43081j commented Nov 6, 2025

This adds a new withBorder option which decides if the standard clack left border is rendered or not.

Not all prompts implement this yet. We can add support for more prompts over time.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

🦋 Changeset detected

Latest commit: 2d0be2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clack/prompts Patch
@clack/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 6, 2025

@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@409
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@409

commit: 2d0be2f

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😁

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely in favor of anything that makes theming easier! Always hoped people would use @clack/core to create their own branded experiences, but that package is still a bit too low-level...

Maybe we should consider adding a theme to the global ClackSettings that could be a hook for global stylistic changes like this? Seems a bit frustrating to require passing withBorder: false every time.

@43081j
Copy link
Collaborator Author

43081j commented Nov 7, 2025

the global settings have their downsides too, since you may not always want to every prompt to follow these rules

maybe in a follow up change, we can make the global settings inherit some of the shared settings, and the inline option takes precedence. i.e. if you set global withBorder but pass withBorder: true, it'll override it

Copy link
Contributor

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got a minute to take a look! Thanks @43081j!

@43081j
Copy link
Collaborator Author

43081j commented Nov 14, 2025

i've renamed this to withGuide and have also reintroduced the prefix to text prompts

@delucis could you take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants