Skip to content

Commit 6b26f18

Browse files
authored
Update setTimeoutSec page object method (#1072)
Added wait object update when timeoutSec value changes.
1 parent 2301b63 commit 6b26f18

File tree

8 files changed

+8
-0
lines changed

8 files changed

+8
-0
lines changed

selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/BasePage.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public BasePage(WebDriver driver) {
4444

4545
public void setTimeoutSec(int timeoutSec) {
4646
this.timeoutSec = timeoutSec;
47+
this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec));
4748
}
4849

4950
public void visit(String url) {

selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/ExtendedBasePage.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public ExtendedBasePage(String browser) {
4747

4848
public void setTimeoutSec(int timeoutSec) {
4949
this.timeoutSec = timeoutSec;
50+
this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec));
5051
}
5152

5253
public void quit() {

selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/BasePage.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public BasePage(WebDriver driver) {
4444

4545
public void setTimeoutSec(int timeoutSec) {
4646
this.timeoutSec = timeoutSec;
47+
this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec));
4748
}
4849

4950
public void visit(String url) {

selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/ExtendedBasePage.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public ExtendedBasePage(String browser) {
4747

4848
public void setTimeoutSec(int timeoutSec) {
4949
this.timeoutSec = timeoutSec;
50+
this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec));
5051
}
5152

5253
public void quit() {

selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/BasePage.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public BasePage(WebDriver driver) {
4444

4545
public void setTimeoutSec(int timeoutSec) {
4646
this.timeoutSec = timeoutSec;
47+
this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec));
4748
}
4849

4950
public void visit(String url) {

selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/ExtendedBasePage.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public ExtendedBasePage(String browser) {
4747

4848
public void setTimeoutSec(int timeoutSec) {
4949
this.timeoutSec = timeoutSec;
50+
this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec));
5051
}
5152

5253
public void quit() {

selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/BasePage.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public BasePage(WebDriver driver) {
4444

4545
public void setTimeoutSec(int timeoutSec) {
4646
this.timeoutSec = timeoutSec;
47+
this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec));
4748
}
4849

4950
public void visit(String url) {

selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/ExtendedBasePage.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public ExtendedBasePage(String browser) {
4747

4848
public void setTimeoutSec(int timeoutSec) {
4949
this.timeoutSec = timeoutSec;
50+
this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec));
5051
}
5152

5253
public void quit() {

0 commit comments

Comments
 (0)