refactor: 파라미터 형식 변경

- 레포지토리의 getProjectToMember 메서드 파라미터를 project가 아닌 projectId만 받도록 변경
- 서비스의 isProjectMember, isProjectLeader 메서드 파라미터를 project가 아닌 projectId만 받도록 변경
- 서비스 메서드의 변경으로 인해 영향을 받는 컨트롤러 계층의 인수 수정

Author: choyoungwoo9

backend/src/project/project.controller.ts

@@ -61,7 +61,7 @@ export class ProjectController {
     if (!project) throw new NotFoundException();
 
     const isProjectMember = await this.projectService.isProjectMember(
-      project,
+      project.id,
       request.member,
     );
     if (isProjectMember)
@@ -71,7 +71,9 @@ export class ProjectController {
       await this.projectService.addMember(project, request.member);
     } catch (err) {
       if (err.message === 'Project reached its maximum member capacity')
-        throw new ConflictException('Project reached its maximum member capacity');
+        throw new ConflictException(
+          'Project reached its maximum member capacity',
+        );
       throw err;
     }
     this.projectWebsocketGateway.notifyJoinToConnectedMembers(

backend/src/project/project.repository.ts

@@ -95,11 +95,11 @@ export class ProjectRepository {
   }
 
   getProjectToMember(
-    project: Project,
+    projectId: number,
     member: Member,
   ): Promise<ProjectToMember | null> {
     return this.projectToMemberRepository.findOne({
-      where: { project: { id: project.id }, member: { id: member.id } },
+      where: { project: { id: projectId }, member: { id: member.id } },
     });
   }
 

backend/src/project/service/project.service.spec.ts

@@ -85,18 +85,6 @@ describe('ProjectService', () => {
     });
   });
 
-  describe('Get project', () => {
-    const project = Project.of('title', 'subject');
-    const projectId = 1;
-    it('should return project', async () => {
-      jest.spyOn(projectRepository, 'getProject').mockResolvedValue(project);
-      const result = await projectService.getProject(projectId);
-
-      expect(projectRepository.getProject).toHaveBeenCalledWith(projectId);
-      expect(result).toEqual(project);
-    });
-  });
-
   describe('Add Member', () => {
     const project = Project.of('title', 'subject');
     project.inviteLinkId = 'inviteUuid';

backend/src/project/service/project.service.ts

@@ -32,7 +32,7 @@ export class ProjectService {
     title: string,
     subject: string,
   ): Promise<boolean> {
-    if (!(await this.isProjectLeader(project, member))) {
+    if (!(await this.isProjectLeader(project.id, member))) {
       throw new Error('Member is not the project leader');
     }
     return this.projectRepository.updateProjectInfo(project, title, subject);
@@ -47,7 +47,7 @@ export class ProjectService {
   }
 
   async addMember(project: Project, member: Member): Promise<void> {
-    const isProjectMember = await this.isProjectMember(project, member);
+    const isProjectMember = await this.isProjectMember(project.id, member);
     if (isProjectMember) throw new Error('already joined member');
 
     if ((await this.getProjectMemberList(project)).length >= 10)
@@ -64,16 +64,16 @@ export class ProjectService {
     return this.projectRepository.getProjectMemberList(project);
   }
 
-  async isProjectMember(project: Project, member: Member): Promise<boolean> {
+  async isProjectMember(projectId: number, member: Member): Promise<boolean> {
     const projectToMember: ProjectToMember | null =
-      await this.projectRepository.getProjectToMember(project, member);
+      await this.projectRepository.getProjectToMember(projectId, member);
     if (!projectToMember) return false;
     return true;
   }
 
-  async isProjectLeader(project: Project, member: Member): Promise<boolean> {
+  async isProjectLeader(projectId: number, member: Member): Promise<boolean> {
     const projectToMember = await this.projectRepository.getProjectToMember(
-      project,
+      projectId,
       member,
     );
     return projectToMember?.role === MemberRole.LEADER;

backend/src/project/websocket.gateway.ts

@@ -229,7 +229,7 @@ export class ProjectWebsocketGateway
     const project = await this.projectService.getProject(client.projectId);
     if (!project) throw new Error('Project not found');
     const isProjectMember = await this.projectService.isProjectMember(
-      project,
+      project.id,
       client.member,
     );
     if (!isProjectMember) throw new Error('Not project member');

backend/src/project/ws-controller/ws-project.controller.ts

@@ -67,7 +67,7 @@ export class WsProjectController {
   async joinSettingPage(client: ClientSocket) {
     if (
       !(await this.projectService.isProjectLeader(
-        client.project,
+        client.project.id,
         client.member,
       ))
     ) {