Convert large integer into string and set as MYSQL_TYPE_NEWDECIMAL

Author: nurse

ext/mysql2/statement.c

@@ -205,7 +205,7 @@ static void set_buffer_for_string(MYSQL_BIND* bind_buffer, unsigned long *length
   }
 
 /* return 0 if the given bignum can cast as LONG_LONG, otherwise 1 */
-int my_big2ll(VALUE bignum, LONG_LONG *ptr)
+static int my_big2ll(VALUE bignum, LONG_LONG *ptr)
 {
     unsigned LONG_LONG num;
 #ifdef HAVE_RB_ABSINT_SIZE
@@ -292,8 +292,22 @@ static VALUE execute(int argc, VALUE *argv, VALUE self) {
           break;
         case T_BIGNUM:
           bind_buffers[i].buffer_type = MYSQL_TYPE_LONGLONG;
-          bind_buffers[i].buffer = xmalloc(sizeof(long long int));
-          my_big2ll(argv[i], (LONG_LONG*)(bind_buffers[i].buffer));
+          {
+              LONG_LONG num;
+              if (my_big2ll(argv[i], &num)) {
+                  VALUE rb_val_as_string = rb_big2str(argv[i], 10);
+                  bind_buffers[i].buffer_type = MYSQL_TYPE_NEWDECIMAL;
+                  params_enc[i] = rb_val_as_string;
+#ifdef HAVE_RUBY_ENCODING_H
+                  params_enc[i] = rb_str_export_to_enc(params_enc[i], conn_enc);
+#endif
+                  set_buffer_for_string(&bind_buffers[i], &length_buffers[i], params_enc[i]);
+              }
+              else {
+                  bind_buffers[i].buffer = xmalloc(sizeof(long long int));
+                  *(LONG_LONG*)(bind_buffers[i].buffer) = num;
+              }
+          }
           break;
         case T_FLOAT:
           bind_buffers[i].buffer_type = MYSQL_TYPE_DOUBLE;

spec/mysql2/statement_spec.rb

@@ -71,9 +71,9 @@
   it "should handle bignum but beyond int64_t" do
     stmt = @client.prepare('SELECT ? AS max1, ? AS min1')
     int64_max1 = (1 << 63)
-    int64_min1 = -(1 << 63) - 2
+    int64_min1 = -(1 << 63) - 1
     result = stmt.execute(int64_max1, int64_min1)
-    expect(result.to_a).to eq(['max1' => -1, 'min1' => -1])
+    expect(result.to_a).to eq(['max1' => "9223372036854775808", 'min1' => "-9223372036854775809"])
     @client.query 'DROP TABLE IF EXISTS mysql2_stmt_q'
   end