RN fixture update: Disable certain scenarios in hermes until PLAT-8236

Author: Cawllec

.buildkite/react-native-pipeline.yml

@@ -109,8 +109,8 @@ steps:
     artifact_paths:
       - build/rn0.67-hermes.apk
 
-  - label: ':ios: Build RN 0.67 ipa'
-    key: "rn-0-67-ipa"
+  - label: ':ios: Build RN 0.67 (hermes) ipa'
+    key: "rn-0-67-hermes-ipa"
     timeout_in_minutes: 60
     agents:
       queue: "opensource-arm-mac-cocoa-12"
@@ -363,6 +363,7 @@ steps:
           - --fail-fast
     env:
       SKIP_NAVIGATION_SCENARIOS: "true"
+      HERMES: "true"
     concurrency: 9
     concurrency_group: 'browserstack-app'
     concurrency_method: eager
@@ -415,8 +416,8 @@ steps:
     concurrency_group: 'browserstack-app'
     concurrency_method: eager
 
-  - label: ':ios: RN 0.67 iOS 14 end-to-end tests'
-    depends_on: "rn-0-67-ipa"
+  - label: ':ios: RN 0.67 (hermes) iOS 14 end-to-end tests'
+    depends_on: "rn-0-67-hermes-ipa"
     timeout_in_minutes: 60
     plugins:
       artifacts#v1.5.0:
@@ -435,6 +436,7 @@ steps:
           - --fail-fast
     env:
       SKIP_NAVIGATION_SCENARIOS: "true"
+      HERMES: "true"
     concurrency: 9
     concurrency_group: 'browserstack-app'
     concurrency_method: eager

docker-compose.yml

@@ -244,6 +244,7 @@ services:
       BROWSER_STACK_USERNAME:
       BROWSER_STACK_ACCESS_KEY:
       SKIP_NAVIGATION_SCENARIOS:
+      HERMES:
     networks:
       default:
         aliases:

test/react-native/features/native-stack.feature

@@ -1,6 +1,7 @@
 Feature: Native stacktrace is parsed for promise rejections
 
-@android_only
+# Skip until PLAT-8236 is complete
+@android_only @skip_hermes
 Scenario: Handled JS error with native stacktrace
   When I run "NativeStackHandledScenario"
   Then I wait to receive an error
@@ -31,7 +32,8 @@ Scenario: Handled JS error with native stacktrace
   And the error payload field "events.0.exceptions.0.stacktrace.13.lineNumber" is not null
   And the error payload field "events.0.exceptions.0.stacktrace.13.type" is null
 
-@android_only
+# Skip until PLAT-8236 is complete
+@android_only @skip_hermes
 Scenario: Unhandled JS error with native stacktrace
   When I run "NativeStackUnhandledScenario"
   Then I wait to receive an error
@@ -69,8 +71,9 @@ Scenario: Unhandled JS error with native stacktrace
 #   And the error payload field "events.0.exceptions.1.stacktrace.1.lineNumber" equals 1
 #   And the error payload field "events.0.exceptions.1.stacktrace.2.lineNumber" equals 2
 
+# Skip until PLAT-8236 is complete
 @skip
-@ios_only
+@ios_only @skip_hermes
 Scenario: Handled JS error with native stacktrace
   When I run "NativeStackHandledScenario"
   Then I wait to receive an error
@@ -99,7 +102,8 @@ Scenario: Handled JS error with native stacktrace
   And the error payload field "events.0.exceptions.0.stacktrace.20.lineNumber" is not null
   And the error payload field "events.0.exceptions.0.stacktrace.20.type" is null
 
-@ios_only
+# Skip until PLAT-8236 is complete
+@ios_only @skip_hermes
 Scenario: Unhandled JS error with native stacktrace
   When I run "NativeStackUnhandledScenario"
   Then I wait to receive an error

test/react-native/features/override_unhandled.feature

@@ -11,6 +11,8 @@ Scenario: Non-fatal error overridden to unhandled
     And the event "session.events.handled" equals 0
     And the event "session.events.unhandled" equals 1
 
+# Skip until PLAT-8236 is complete
+@skip_hermes
 Scenario: Fatal error overridden to handled
     When I run "UnhandledOverrideJsErrorScenario" and relaunch the crashed app
     And I configure Bugsnag for "UnhandledOverrideJsErrorScenario"

test/react-native/features/support/env.rb

@@ -4,13 +4,18 @@
 end
 
 Before('@android_only') do |scenario|
-  skip_this_scenario("Skipping scenario") if Maze.driver.capabilities["os"] == 'ios'
+  skip_this_scenario("Skipping scenario") if Maze.driver.capabilities["os"].eql?('ios')
 end
 
 Before('@ios_only') do |scenario|
-  skip_this_scenario("Skipping scenario") if Maze.driver.capabilities["os"] == 'android'
+  skip_this_scenario("Skipping scenario") if Maze.driver.capabilities["os"].eql?('android')
 end
 
 Before('@navigation') do |scenario|
-  skip_this_scenario("Skipping scenario") if ENV['SKIP_NAVIGATION_SCENARIOS'] == 'true'
+  skip_this_scenario("Skipping scenario") if ENV['SKIP_NAVIGATION_SCENARIOS'].eql?('true')
+end
+
+# Require until PLAT-8236 is implemented
+Before('@skip_hermes') do |_scenario|
+  skip_this_scenario("Skipping scenario") if ENV['HERMES'].eql?('true')
 end

test/react-native/features/unhandled.feature

@@ -9,6 +9,8 @@ Scenario: Catching an Unhandled error
   And the event "unhandled" is true
   And the exception "message" equals "UnhandledJsErrorScenario"
 
+# Skip until PLAT-8236 is complete
+@skip_hermes
 Scenario: Catching an Unhandled promise rejection
   When I run "UnhandledJsPromiseRejectionScenario"
   Then I wait to receive an error