Skip to content

Commit d13ed53

Browse files
authored
Revert browserstack non-https tests to ios_11 (#2586)
* revert browserstack non-https tests to ios_11 * add android 9 test device * reinstate ios_11 browser error code assertions
1 parent a5fc9f0 commit d13ed53

File tree

2 files changed

+30
-5
lines changed

2 files changed

+30
-5
lines changed

.buildkite/basic/browser-pipeline.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ steps:
5050
#
5151
- label: ":browserstack: {{matrix}} non-https tests"
5252
matrix:
53-
- ios_12
53+
- ios_11
5454
- safari_16
5555
depends_on: "browser-maze-runner-bs"
5656
timeout_in_minutes: 30
@@ -82,7 +82,7 @@ steps:
8282
- edge_17
8383
- safari_10
8484
- ios_15
85-
- android_8
85+
- android_9
8686
- chrome_43
8787
- chrome_72
8888
- firefox_78
@@ -109,7 +109,6 @@ steps:
109109
concurrency_group: "browserstack"
110110
concurrency_method: eager
111111

112-
113112
#
114113
# BitBar tests
115114
#
@@ -170,4 +169,4 @@ steps:
170169
concurrency_group: "bitbar"
171170
concurrency_method: eager
172171
env:
173-
HOST: "localhost" # IE11 needs the host set to localhost for some reason
172+
HOST: "localhost" # IE11 needs the host set to localhost

test/browser/features/fixtures/browser_errors.yml

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ safari_16:
103103
lineNumber: 18
104104
columnNumber: 25
105105

106-
ios_12:
106+
ios_11:
107107
handled:
108108
errorClass: 'ReferenceError'
109109
errorMessage: "Can't find variable: foo"
@@ -259,6 +259,32 @@ android_8:
259259
lineNumber: 18
260260
columnNumber: 7
261261

262+
android_9:
263+
handled:
264+
errorClass: 'ReferenceError'
265+
errorMessage: 'foo is not defined'
266+
unhandled_syntax:
267+
errorClass: 'SyntaxError'
268+
errorMessage: "Unexpected token '!'"
269+
lineNumber: 18
270+
columnNumber: 13
271+
file: '/unhandled/script/a.html'
272+
unhandled_thrown:
273+
errorClass: 'Error'
274+
errorMessage: "bad things"
275+
lineNumber: 18
276+
columnNumber: 13
277+
unhandled_undefined_function:
278+
errorClass: 'ReferenceError'
279+
errorMessage: nevergoingtoexist_notinamillionyears is not defined
280+
lineNumber: 18
281+
columnNumber: 7
282+
unhandled_malformed_uri:
283+
errorClass: 'URIError'
284+
errorMessage: URI malformed
285+
lineNumber: 18
286+
columnNumber: 7
287+
262288
firefox_78:
263289
handled:
264290
errorClass: 'ReferenceError'

0 commit comments

Comments
 (0)