Skip to content

Commit 9091093

Browse files
author
Steve Kirkland
committed
Make naming consistent with existing constants
1 parent ece95c2 commit 9091093

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

lib/bugsnag.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -526,10 +526,10 @@ def check_key_valid
526526
def check_endpoint_setup
527527
notify_set = configuration.notify_endpoint &&
528528
configuration.notify_endpoint != Bugsnag::Configuration::DEFAULT_NOTIFY_ENDPOINT &&
529-
configuration.notify_endpoint != Bugsnag::Configuration::HUB_NOTIFY
529+
configuration.notify_endpoint != Bugsnag::Configuration::HUB_NOTIFY_ENDPOINT
530530
session_set = configuration.session_endpoint &&
531531
configuration.session_endpoint != Bugsnag::Configuration::DEFAULT_SESSION_ENDPOINT &&
532-
configuration.session_endpoint != Bugsnag::Configuration::HUB_SESSION
532+
configuration.session_endpoint != Bugsnag::Configuration::HUB_SESSION_ENDPOINT
533533
if notify_set && !session_set
534534
configuration.warn("The session endpoint has not been set, all further session capturing will be disabled")
535535
configuration.disable_sessions

lib/bugsnag/configuration.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,8 @@ class Configuration
199199

200200
DEFAULT_NOTIFY_ENDPOINT = "https://notify.bugsnag.com"
201201
DEFAULT_SESSION_ENDPOINT = "https://sessions.bugsnag.com"
202-
HUB_NOTIFY = "https://notify.insighthub.smartbear.com"
203-
HUB_SESSION = "https://sessions.insighthub.smartbear.com"
202+
HUB_NOTIFY_ENDPOINT = "https://notify.insighthub.smartbear.com"
203+
HUB_SESSION_ENDPOINT = "https://sessions.insighthub.smartbear.com"
204204
HUB_PREFIX = "00000"
205205

206206
DEFAULT_META_DATA_FILTERS = [
@@ -549,7 +549,7 @@ def set_default_endpoints
549549
return unless @endpoints.notify.nil? && @endpoints.sessions.nil?
550550

551551
self.endpoints = if hub_api_key?
552-
EndpointConfiguration.new(HUB_NOTIFY, HUB_SESSION)
552+
EndpointConfiguration.new(HUB_NOTIFY_ENDPOINT, HUB_SESSION_ENDPOINT)
553553
else
554554
EndpointConfiguration.new(DEFAULT_NOTIFY_ENDPOINT, DEFAULT_SESSION_ENDPOINT)
555555
end

spec/configuration_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -445,8 +445,8 @@ def output_lines
445445
Bugsnag.configure do |config|
446446
config.api_key = '00000472bd130ac0ab0f52715bbdc600'
447447
end
448-
expect(Bugsnag.configuration.endpoints.notify).to eq(Bugsnag::Configuration::HUB_NOTIFY)
449-
expect(Bugsnag.configuration.endpoints.sessions).to eq(Bugsnag::Configuration::HUB_SESSION)
448+
expect(Bugsnag.configuration.endpoints.notify).to eq(Bugsnag::Configuration::HUB_NOTIFY_ENDPOINT)
449+
expect(Bugsnag.configuration.endpoints.sessions).to eq(Bugsnag::Configuration::HUB_SESSION_ENDPOINT)
450450
end
451451
end
452452
end

0 commit comments

Comments
 (0)