Enable default workflows config by default

Author: maggie-lou

docs/workflows-config.md

@@ -5,11 +5,12 @@ sidebar_label: Workflows configuration
 ---
 
 Once you've linked your repo to BuildBuddy via
-[BuildBuddy workflows](workflows-setup.md), BuildBuddy will automatically
-run `bazel test //...` on each push to your repo, reporting results to the
-BuildBuddy UI.
+[BuildBuddy workflows](workflows-setup.md), there are two ways to start running Workflows.
 
-But you may wish to configure multiple test commands with different test
+The default workflow config runs `bazel test //...` whenever a commit is pushed to your repo's default branch or a pull request branch is updated. In order to enable this, click `Enable default workflow config`
+in the three-dot dropdown for your repository on the Workflows page.
+
+You may wish to configure multiple test commands with different test
 tag filters, or run the same tests on multiple different platform
 configurations (running some tests on Linux, and some on macOS, for
 example).

docs/workflows-setup.md

@@ -33,15 +33,14 @@ To enable workflows, take the following steps:
 
 ## Running workflows
 
-Once a repository is linked, BuildBuddy will automatically run `bazel test //...` whenever a commit is pushed to your repo's default branch
-or whenever a pull request branch is updated. It will report commit
-statuses to GitHub, which you can see on the repo's home page or in pull
-request branches. The "Details" links in these statuses point to the
-BuildBuddy UI, where you can see the result of the workflow run.
+After you've linked a repository, there are two ways to start running Workflows:
 
-## Configuring your workflow
+The default workflow config runs `bazel test //...` whenever a commit is pushed to your repo's default branch or a pull request branch is updated. In order to enable this, click `Enable default workflow config`
+in the three-dot dropdown for your repository on the Workflows page.
 
-To learn how to change the default configuration, see [workflows configuration](workflows-config.md).
+In order to configure more complex workflows - i.e. different trigger conditions or running different commands - you will need to add a file called `buildbuddy.yaml` to the root of your git repo. See [workflows configuration](workflows-config.md) for more details..
+
+Workflows will report commit statuses to GitHub, which you can see on the repo's home page or in pull request branches. The "Details" links in these statuses point to the BuildBuddy UI, where you can see the result of the workflow run.
 
 ## Setting up branch protection rules
 

enterprise/server/githubapp/githubapp.go

@@ -271,7 +271,13 @@ func (s *GitHubAppService) GetLinkedGitHubRepos(ctx context.Context) (*ghpb.GetL
 	`, u.GetGroupID())
 	res := &ghpb.GetLinkedReposResponse{}
 	err = db.ScanEach(rq, func(ctx context.Context, row *tables.GitRepository) error {
+		// TODO(Maggie): Clean up after BE change is deployed
 		res.RepoUrls = append(res.RepoUrls, row.RepoURL)
+
+		res.Repos = append(res.Repos, &ghpb.GitRepository{
+			RepoUrl:                  row.RepoURL,
+			UseDefaultWorkflowConfig: row.UseDefaultWorkflowConfig,
+		})
 		return nil
 	})
 	if err != nil {
@@ -862,6 +868,31 @@ func (a *GitHubApp) UnlinkGitHubRepo(ctx context.Context, req *ghpb.UnlinkRepoRe
 	return &ghpb.UnlinkRepoResponse{}, nil
 }
 
+func (a *GitHubApp) UpdateRepoSettings(ctx context.Context, req *ghpb.UpdateRepoSettingsRequest) (*ghpb.UpdateRepoSettingsResponse, error) {
+	norm, err := gitutil.NormalizeRepoURL(req.GetRepoUrl())
+	if err != nil {
+		return nil, status.InvalidArgumentErrorf("failed to parse repo URL: %s", err)
+	}
+	normalizedURL := norm.String()
+	u, err := a.env.GetAuthenticator().AuthenticatedUser(ctx)
+	if err != nil {
+		return nil, err
+	}
+	result := a.env.GetDBHandle().NewQuery(ctx, "githubapp_update_repo_settings").Raw(`
+		UPDATE "GitRepositories"
+		SET use_default_workflow_config = ?
+		WHERE group_id = ?
+		AND repo_url = ?
+	`, req.GetUseDefaultWorkflowConfig(), u.GetGroupID(), normalizedURL).Exec()
+	if result.Error != nil {
+		return nil, status.InternalErrorf("failed to update repo settings: %s", result.Error)
+	}
+	if result.RowsAffected == 0 {
+		return nil, status.NotFoundError("repo not found")
+	}
+	return &ghpb.UpdateRepoSettingsResponse{}, nil
+}
+
 func (a *GitHubApp) GetAccessibleGitHubRepos(ctx context.Context, req *ghpb.GetAccessibleReposRequest) (*ghpb.GetAccessibleReposResponse, error) {
 	req.Query = strings.TrimSpace(req.Query)
 

proto/buildbuddy_service.proto

@@ -205,6 +205,8 @@ service BuildBuddyService {
   rpc LinkGitHubRepo(github.LinkRepoRequest) returns (github.LinkRepoResponse);
   rpc UnlinkGitHubRepo(github.UnlinkRepoRequest)
       returns (github.UnlinkRepoResponse);
+  rpc UpdateGitHubRepoSettings(github.UpdateRepoSettingsRequest)
+      returns (github.UpdateRepoSettingsResponse);
 
   // Installation-repos API (authenticates w/ GitHub using
   // installation access token)

proto/github.proto

@@ -182,10 +182,24 @@ message GetLinkedReposRequest {
   context.RequestContext request_context = 1;
 }
 
+message GitRepository {
+  string repo_url = 1;
+
+  // Whether to use the default workflow config if buildbuddy.yaml is missing.
+  // If enabled, workflows will automatically start running for a git repo when linked,
+  // even if buildbuddy.yaml is missing from the repo. If disabled, workflows will only run
+  // when buildbuddy.yaml is present in the repo.
+  bool use_default_workflow_config = 2;
+}
+
 message GetLinkedReposResponse {
   context.ResponseContext response_context = 1;
 
-  repeated string repo_urls = 2;
+  repeated GitRepository repos = 3;
+
+  // DEPRECATED: Use repos instead.
+  repeated string repo_urls = 2 [deprecated = true];
+
 }
 
 // A request to link a repo to the authenticated org.
@@ -218,6 +232,18 @@ message UnlinkRepoResponse {
   context.ResponseContext response_context = 1;
 }
 
+message UpdateRepoSettingsRequest {
+  context.RequestContext request_context = 1;
+
+  string repo_url = 2;
+
+  bool use_default_workflow_config = 3;
+}
+
+message UpdateRepoSettingsResponse {
+  context.ResponseContext response_context = 1;
+}
+
 message GetGithubAppInstallPathRequest {
   context.RequestContext request_context = 1;
 }

server/buildbuddy_server/buildbuddy_server.go

@@ -1756,6 +1756,27 @@ func (s *BuildBuddyServer) UnlinkGitHubRepo(ctx context.Context, req *ghpb.Unlin
 	}
 	return rsp, nil
 }
+
+func (s *BuildBuddyServer) UpdateGitHubRepoSettings(ctx context.Context, req *ghpb.UpdateRepoSettingsRequest) (*ghpb.UpdateRepoSettingsResponse, error) {
+	gh := s.env.GetGitHubAppService()
+	if gh == nil {
+		return nil, status.UnimplementedError("Not implemented")
+	}
+	repo, err := git.ParseGitHubRepoURL(req.GetRepoUrl())
+	if err != nil {
+		return nil, err
+	}
+	a, err := gh.GetGitHubAppForOwner(ctx, repo.Owner)
+	if err != nil {
+		return nil, err
+	}
+	rsp, err := a.UpdateRepoSettings(ctx, req)
+	if err != nil {
+		return nil, err
+	}
+	return rsp, nil
+}
+
 func (s *BuildBuddyServer) GetGitHubAppInstallPath(ctx context.Context, req *ghpb.GetGithubAppInstallPathRequest) (*ghpb.GetGithubAppInstallPathResponse, error) {
 	gh := s.env.GetGitHubAppService()
 	if gh == nil {

server/capabilities_filter/capabilities_filter.go

@@ -166,6 +166,7 @@ var (
 		"GetGitHubAppInstallPath",
 		"LinkGitHubRepo",
 		"UnlinkGitHubRepo",
+		"UpdateGitHubRepoSettings",
 		// Org API key management
 		"CreateApiKey",
 		"UpdateApiKey",

server/interfaces/interfaces.go

@@ -682,6 +682,7 @@ type GitHubApp interface {
 
 	LinkGitHubRepo(ctx context.Context, repoURL string) (*ghpb.LinkRepoResponse, error)
 	UnlinkGitHubRepo(context.Context, *ghpb.UnlinkRepoRequest) (*ghpb.UnlinkRepoResponse, error)
+	UpdateRepoSettings(context.Context, *ghpb.UpdateRepoSettingsRequest) (*ghpb.UpdateRepoSettingsResponse, error)
 
 	GetAccessibleGitHubRepos(context.Context, *ghpb.GetAccessibleReposRequest) (*ghpb.GetAccessibleReposResponse, error)