Save File Dialog with non-English Windows languages

[infeeeee]

On non-English Windows installations(not Revit), Windows replaces the buttons on the save file dialog to the language's counterparts. My Windows is installed in Hungarian, and on the Save file dialog Yes/No/Cancel is replaced by Igen/Nem/Mégse:

When I forget to add handling of saving/closing the Revit file to the dynamo script, RBP just hangs, and the following shows up in the log:

19:13:38 : 'Save File' dialog box detected.
19:13:38 : 
19:13:38 : WARNING: Could not find suitable button to click for 'Save File' dialog box!
19:13:38 : 
19:13:38 : 	Button: 'Igen'
19:13:38 : 
19:13:38 : 	Button: 'Nem'
19:13:38 : 
19:13:38 : 	Button: 'M‚gse'

My feature request/question is: is it possible to modify the "suitable button"?

Edit:

I guess this issue is somewhat related to #10 . So maybe this just a head's up, so please add support for non-english languages when you work on the saving methods. Thank you for your work again!

[DanRumery]

Hi @infeeeee

Indeed I imagine this happens to quite a lot of users given they probably use locale-specific Windows. Is it only the Windows-style dialogs that are presented in the local language? Do all Revit dialogs have local language text or are they mostly still in english? It's gonna be difficult to accommodate all the variations for the many dialogs that RBP tries to handle. If it's only the save dialog then yes I could add a configuration file that allows for custom dialog and button text for save dialog detection.

Incidently it looks like the log output isn't displaying unicode characters correctly either (Mégse vs M,gse).

[DanRumery]

Actually, do all the Revit dialogs with standard buttons (OK, Cancel, etc) have their button text displayed in the locale-specific language?

[infeeeee]

It's not that common, it's only the Windows style dialogs. In Revit everything is in English. It seems, that this dialogs has white background. Dialogs with greyish background are always in English.

I collected some of them I found while working. If I find more, I will update this post.

[DanRumery]

Thanks for documenting these @infeeeee

Interesting that the OK button still says OK 😁

So I take it that these are the mappings to the english button:

OK - OK button
Igen - Yes button
Nem - No button
Bezaras - Close button
Megse - Cancel button

I am thinking that the user could make a text file with the mapping for each of these standard buttons, specify it in the settings file, and then RBP would check for this file and if found, substitute those button names when searching for the suitable button to click.

I assume that these are the only buttons that are replaced by the local language settings.

[infeeeee]

The OK is OK because in Hungarian we use OK as well. If I change Windows language to Arabic, it's changed to it's Arabic counterpart, so it's also translated:

The test file mapping would be a good solution. Maybe there are more suitable file types than a simple text file, e.g. a po file, but if only these 5 strings would be translated it doesn't really matter.

[NicklasOestergaard]

Is there anything I can do to help fix this error?

[jsrubianoj]

I think is doable for any language but we should find a better way to do it. I implemented the dialog detection for Spanish a long time ago, since many users in my past company needed that. You can try to hardcode it like I did while we find a better way to do it. Probably it would be best to have a JSON file with the equivalent value for the errors already being detected for each new language.