feat: Use fetcher in workflow history (#1064)

* Create fetcher utility

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* rename query

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* Create hook for fetching history

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* add configurable throttleMs to the hook

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* use fetcher in workflow history

* remove useKeepLoadingEvents

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* update fetcher based on feedback

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* rename unmout to destroy

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* Create hook for fetching history

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* move condition into executeImmediately

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* update destroy in method

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* fix type error with query params

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

---------

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

Author: Assem-Uber

src/views/workflow-history/__tests__/workflow-history.test.tsx

@@ -28,6 +28,15 @@ jest.mock('@/hooks/use-page-query-params/use-page-query-params', () =>
   jest.fn(() => [{ historySelectedEventId: '1' }, jest.fn()])
 );
 
+// Mock the hook to use minimal throttle delay for faster tests
+jest.mock('../hooks/use-workflow-history-fetcher', () => {
+  const actual = jest.requireActual('../hooks/use-workflow-history-fetcher');
+  return {
+    __esModule: true,
+    default: jest.fn((params) => actual.default(params, 0)), // 0ms throttle for tests
+  };
+});
+
 jest.mock(
   '../workflow-history-compact-event-card/workflow-history-compact-event-card',
   () => jest.fn(() => <div>Compact group Card</div>)
@@ -90,24 +99,24 @@ describe('WorkflowHistory', () => {
   });
 
   it('renders page header correctly', async () => {
-    setup({});
+    await setup({});
     expect(
       await screen.findByText('Workflow history Header')
     ).toBeInTheDocument();
   });
 
   it('renders compact group cards', async () => {
-    setup({});
+    await setup({});
     expect(await screen.findByText('Compact group Card')).toBeInTheDocument();
   });
 
   it('renders timeline group cards', async () => {
-    setup({});
+    await setup({});
     expect(await screen.findByText('Timeline group card')).toBeInTheDocument();
   });
 
   it('renders load more section', async () => {
-    setup({});
+    await setup({});
     expect(await screen.findByText('Load more')).toBeInTheDocument();
   });
 
@@ -180,7 +189,7 @@ describe('WorkflowHistory', () => {
   });
 
   it('should show no results when filtered events are empty', async () => {
-    setup({ emptyEvents: true });
+    await setup({ emptyEvents: true });
     expect(await screen.findByText('No Results')).toBeInTheDocument();
   });
 

src/views/workflow-history/hooks/__tests__/use-keep-loading-events.test.ts

@@ -227,8 +227,6 @@ function setup(props: Partial<Props> = {}) {
       cluster: 'test-cluster',
       workflowId: 'test-workflowId',
       runId: 'test-runId',
-      pageSize: 100,
-      waitForNewEvent: 'true',
     },
     pageFiltersProps: {
       activeFiltersCount: 0,

src/views/workflow-history/hooks/use-keep-loading-events.ts

@@ -8,10 +8,6 @@ import { type Props as WorkflowHistoryExportJsonButtonProps } from '../workflow-
 import { type Props as WorkflowHistoryTimelineChartProps } from '../workflow-history-timeline-chart/workflow-history-timeline-chart.types';
 
 type WorkflowPageQueryParamsConfig = typeof workflowPageQueryParamsConfig;
-type WorkflowHistoryRequestArgs = WorkflowHistoryExportJsonButtonProps & {
-  pageSize: number;
-  waitForNewEvent: string;
-};
 
 type PageFiltersProps = {
   resetAllFilters: () => void;
@@ -25,7 +21,7 @@ export type Props = {
   toggleIsExpandAllEvents: () => void;
   isUngroupedHistoryViewEnabled: boolean;
   onClickGroupModeToggle: () => void;
-  wfHistoryRequestArgs: WorkflowHistoryRequestArgs;
+  wfHistoryRequestArgs: WorkflowHistoryExportJsonButtonProps;
   pageFiltersProps: PageFiltersProps;
   timelineChartProps: WorkflowHistoryTimelineChartProps;
   isStickyEnabled?: boolean;