throw when a module is unreadable so that the cli frontend can format it in a nice way that doesn't disrupt the in-place progress spinner

Author: matthargett

packages/react-native-node-api-modules/src/node/path-utils.test.ts

@@ -41,18 +41,15 @@ describe("isNodeApiModule", () => {
     }
   });
 
-  it("returns false when module file exists but is not readable", (context) => {
+  it("throws when module file exists but is not readable", (context) => {
     const tempDirectoryPath = setupTempDirectory(context, {
       "addon.android.node": "",
     });
     const candidate = path.join(tempDirectoryPath, "addon.android.node");
     // remove read permission on file
     fs.chmodSync(candidate, 0);
     try {
-      assert.equal(
-        isNodeApiModule(path.join(tempDirectoryPath, "addon")),
-        false
-      );
+      assert.throws(() => isNodeApiModule(path.join(tempDirectoryPath, "addon")), /skipping unreadable module addon\.android\.node/);
     } finally {
       fs.chmodSync(candidate, 0o600);
     }
@@ -76,19 +73,15 @@ describe("isNodeApiModule", () => {
     assert.equal(isNodeApiModule(path.join(tempDirectoryPath, "nope")), false);
   });
 
-  it("returns true and warns when one module unreadable but another readable", (context) => {
+  it("throws when one module unreadable but another readable", (context) => {
     const tempDirectoryPath = setupTempDirectory(context, {
       "addon.android.node": "",
       "addon.xcframework": "",
     });
     const unreadable = path.join(tempDirectoryPath, "addon.android.node");
     // only android module is unreadable
     fs.chmodSync(unreadable, 0);
-    const warnings: string[] = [];
-    themock.method(console, 'warn', (msg: string) => warnings.push(msg));
-    const result = isNodeApiModule(path.join(tempDirectoryPath, "addon"));
-    assert.equal(result, true);
-    assert.deepEqual(warnings, ["skipping unreadable module addon.android.node"]);
+    assert.throws(() => isNodeApiModule(path.join(tempDirectoryPath, "addon")), /skipping unreadable module addon\.android\.node/);
     fs.chmodSync(unreadable, 0o600);
   });
 });

packages/react-native-node-api-modules/src/node/path-utils.ts

@@ -26,12 +26,12 @@ export type NamingStrategy = {
 const packageNameCache = new Map<string, string>();
 
 /**
- * @param modulePath The path to the module to check (must be extensionless or end in .node)
- * @returns True if a platform specific prebuild exists for the module path.
+ * @param modulePath  Batch-scans the path to the module to check (must be extensionless or end in .node)
+ * @returns True if a platform specific prebuild exists for the module path, warns on unreadable modules.
+ * @throws If the parent directory cannot be read, or if a detected module is unreadable.
  * TODO: Consider checking for a specific platform extension.
  */
 export function isNodeApiModule(modulePath: string): boolean {
-  // Batch-scan directory, warn on unreadable modules, and detect accessible ones
   const dir = path.dirname(modulePath);
   const baseName = path.basename(modulePath, ".node");
   let entries: string[];
@@ -50,7 +50,7 @@ export function isNodeApiModule(modulePath: string): boolean {
       fs.accessSync(path.join(dir, fileName), fs.constants.R_OK);
       hasReadable = true;
     } catch {
-      console.warn("skipping unreadable module " + fileName);
+      throw new Error("skipping unreadable module " + fileName);
     }
   }
   return hasReadable;