Skip to content

Conversation

@Tim142857
Copy link

There was an issue when we create both STOP_MARKET and TAKE_PROFIT_MARKET for an opened position. When one is trigerred, second order is still active. GTE_GTC allow orders to be removed if their status become "EXPIRED"

@balthazar
Copy link
Collaborator

Actually shouldn't you be the one providing this param yourself rather than making this the default which some people might not expect?

@farukborann
Copy link
Contributor

farukborann commented Sep 19, 2023

I agree, it should not be set by default, but we can set it ourselves.

Something like that :

File: ./node_modules/binance-api-node/index.d.ts
Line 1412 : 
  export type TimeInForce_LT = 'GTC' | 'IOC' | 'FOK' | 'GTE_GTC'

  export const enum TimeInForce {
    GTC = 'GTC',
    IOC = 'IOC',
    FOK = 'FOK',
    GTE_GTC = 'GTE_GTC'
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants