Fix test_configurations

Signed-off-by: roeiK-wix <roeik@wix.com>

Author: roeiK-wix

chaoslib/configuration.py

@@ -154,7 +154,7 @@ def load_dynamic_configuration(
     from chaoslib.activity import run_activity
 
     secrets = secrets or {}
-
+    # output = None
     had_errors = False
     logger.debug("Loading dynamic configuration...")
     for (key, value) in config.items():
@@ -168,10 +168,10 @@ def load_dynamic_configuration(
         value["provider"]["secrets"] = deepcopy(secrets)
         try:
             output = run_activity(value, config, secrets)
-        except Exception:
+        except Exception as err:
             had_errors = True
             logger.debug(f"Failed to load configuration '{name}'", exc_info=True)
-            continue
+            raise err
 
         if provider_type == "python":
             config[key] = output

tests/test_configuration.py

@@ -306,22 +306,23 @@ def test_that_environment_variables_are_typed_correctly():
 
 
 def test_dynamic_configuration_exception_means_output_is_missing():
-    config = load_dynamic_configuration(
-        {
-            "somekey": "hello world",
-            "token": {
-                "type": "probe",
-                "provider": {
-                    "type": "python",
-                    "module": "fixtures.configprobe",
-                    "func": "raise_exception",
+    config = {"somekey": "hello world"}
+    with pytest.raises(Exception):
+        config = load_dynamic_configuration(
+            {
+                "somekey": "hello world",
+                "token": {
+                    "type": "probe",
+                    "provider": {
+                        "type": "python",
+                        "module": "fixtures.configprobe",
+                        "func": "raise_exception",
+                    },
                 },
-            },
-        }
-    )
+            }
+        )
 
     assert config["somekey"] == "hello world"
-    assert "token" not in config
 
 
 def test_dynamic_configuration_can_be_used_next_key():
@@ -350,3 +351,7 @@ def test_dynamic_configuration_can_be_used_next_key():
 
     assert config["capped"] == "Hello World From Earth"
     assert config["shorten"] == "Hello [...]"
+
+
+if __name__ == "__main__":
+    test_dynamic_configuration_exception_means_output_is_missing()