From 8264d9c316d269d26bc16beaf4da7436ddeabbd8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Czapli=C5=84ski?= Date: Wed, 3 Jun 2020 22:05:36 +0200 Subject: [PATCH 1/2] fix compilation in Nim 1.2 on Windows Previous code results in the following error: asynctools\asyncpipe.nim(260, 16) Error: undeclared identifier: 'PCustomOverlapped' --- asynctools/asyncpipe.nim | 1 + 1 file changed, 1 insertion(+) diff --git a/asynctools/asyncpipe.nim b/asynctools/asyncpipe.nim index 5d759d8..c181fe2 100644 --- a/asynctools/asyncpipe.nim +++ b/asynctools/asyncpipe.nim @@ -116,6 +116,7 @@ else: when defined(windows): import winlean + import asyncpty else: import posix From 23ed1765e15ed78367cbf6c2c663b817524d8b52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Czapli=C5=84ski?= Date: Thu, 4 Jun 2020 00:04:04 +0200 Subject: [PATCH 2/2] asyncpipe: explain readInto EOF detection semantics --- asynctools/asyncpipe.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/asynctools/asyncpipe.nim b/asynctools/asyncpipe.nim index c181fe2..49046f9 100644 --- a/asynctools/asyncpipe.nim +++ b/asynctools/asyncpipe.nim @@ -87,7 +87,7 @@ when defined(nimdoc): ## into ``data``, which must at least be of that size. ## ## Returned future will complete once all the data requested is read or - ## part of the data has been read. + ## part of the data has been read. A future with value 0 means end of file. proc asyncWrap*(readHandle: Handle|cint = 0, writeHandle: Handle|cint = 0): AsyncPipe =