Skip to content

Fire detach without ids #45

@ws6125

Description

@ws6125

Hello, this package is useful for my project. But, I have a problem in detach function.
I call detach() without any parameter to detach large number of ids, which will over 65535 of PDO limit, and want to record their events.
I think $result = parent::detach($ids, $touch) this can be modified by check the parameters which user pass, like:

public function detach($ids = null, $touch = true)
  {
      // Check parameters
      $sendIds = (! empty($ids));
      ....
      if ($result = parent::detach(($sendIds) ? $ids : null, $touch)) {
          ....

If there are any further information or solution, please kindly to tell me. Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions