Apply clang-tidy setting: react/nativemodule

Differential Revision: D78634926

Author: christophpurrer

packages/react-native/ReactCommon/react/bridging/tests/ClassTest.cpp

@@ -5,35 +5,40 @@
  * LICENSE file in the root directory of this source tree.
  */
 
+#include <utility>
+
 #include "BridgingTest.h"
 
 namespace facebook::react {
 
 using namespace std::literals;
 
 struct TestClass {
-  TestClass(std::shared_ptr<CallInvoker> invoker) : invoker_(invoker) {}
+  explicit TestClass(std::shared_ptr<CallInvoker> invoker)
+      : invoker_(std::move(invoker)) {}
 
-  double add(jsi::Runtime&, int a, float b) {
+  double add(jsi::Runtime& /*unused*/, int a, float b) {
     return a + b;
   }
 
-  jsi::Object getObject(jsi::Runtime&, jsi::Object obj) {
+  jsi::Object getObject(jsi::Runtime& /*unused*/, jsi::Object obj) {
     return obj;
   }
 
   AsyncPromise<std::string> getPromise(jsi::Runtime& rt, std::string result) {
     auto promise = AsyncPromise<std::string>(rt, invoker_);
-    promise.resolve(result);
+    promise.resolve(std::move(result));
     return promise;
   }
 
-  std::string
-  callFunc(jsi::Runtime&, SyncCallback<std::string(int)> func, int num) {
+  std::string callFunc(
+      jsi::Runtime& /*unused*/,
+      SyncCallback<std::string(int)> func,
+      int num) {
     return func(num);
   }
 
-  void callAsync(jsi::Runtime&, AsyncCallback<> callback) {
+  void callAsync(jsi::Runtime& /*unused*/, const AsyncCallback<>& callback) {
     callback();
   }
 
@@ -69,7 +74,8 @@ TEST_F(BridgingTest, callFromJsTest) {
   then.callWithThis(
       rt,
       promise,
-      bridging::toJs(rt, [&](std::string res) { result = res; }, invoker));
+      bridging::toJs(
+          rt, [&](std::string res) { result = std::move(res); }, invoker));
 
   flushQueue();
   EXPECT_EQ("hi"s, result);

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/CxxTurboModuleUtils.cpp

@@ -7,6 +7,8 @@
 
 #include "CxxTurboModuleUtils.h"
 
+#include <utility>
+
 namespace facebook::react {
 
 std::unordered_map<
@@ -23,10 +25,10 @@ globalExportedCxxTurboModuleMap() {
 }
 
 void registerCxxModuleToGlobalModuleMap(
-    std::string name,
+    const std::string& name,
     std::function<std::shared_ptr<TurboModule>(
         std::shared_ptr<CallInvoker> jsInvoker)> moduleProviderFunc) {
-  globalExportedCxxTurboModuleMap()[name] = moduleProviderFunc;
+  globalExportedCxxTurboModuleMap()[name] = std::move(moduleProviderFunc);
 }
 
 } // namespace facebook::react

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/CxxTurboModuleUtils.h

@@ -28,7 +28,7 @@ globalExportedCxxTurboModuleMap();
  * for example in a `+ load`, your AppDelegate's start, or from Java init.
  */
 void registerCxxModuleToGlobalModuleMap(
-    std::string name,
+    const std::string& name,
     std::function<std::shared_ptr<TurboModule>(
         std::shared_ptr<CallInvoker> jsInvoker)> moduleProviderFunc);
 

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboCxxModule.cpp

@@ -20,10 +20,9 @@ namespace facebook::react {
 
 namespace {
 CxxModule::Callback makeTurboCxxModuleCallback(
-    jsi::Runtime& runtime,
     std::weak_ptr<CallbackWrapper> weakWrapper) {
-  return [weakWrapper,
-          wrapperWasCalled = false](std::vector<folly::dynamic> args) mutable {
+  return [weakWrapper, wrapperWasCalled = false](
+             const std::vector<folly::dynamic>& args) mutable {
     if (wrapperWasCalled) {
       LOG(FATAL) << "callback arg cannot be called more than once";
     }
@@ -77,9 +76,9 @@ jsi::Value TurboCxxModule::create(
         0,
         [this](
             jsi::Runtime& rt,
-            const jsi::Value& thisVal,
-            const jsi::Value* args,
-            size_t count) {
+            const jsi::Value& /*thisVal*/,
+            const jsi::Value* /*args*/,
+            size_t /*count*/) {
           jsi::Object result(rt);
           auto constants = cxxModule_->getConstants();
           for (auto& pair : constants) {
@@ -97,7 +96,7 @@ jsi::Value TurboCxxModule::create(
             0,
             [this, propNameUtf8](
                 jsi::Runtime& rt,
-                const jsi::Value& thisVal,
+                const jsi::Value& /*thisVal*/,
                 const jsi::Value* args,
                 size_t count) {
               return invokeMethod(rt, propNameUtf8, args, count);
@@ -114,8 +113,8 @@ std::vector<jsi::PropNameID> TurboCxxModule::getPropertyNames(
   std::vector<jsi::PropNameID> result;
   result.reserve(cxxMethods_.size() + 1);
   result.push_back(jsi::PropNameID::forUtf8(runtime, "getConstants"));
-  for (auto it = cxxMethods_.begin(); it != cxxMethods_.end(); it++) {
-    result.push_back(jsi::PropNameID::forUtf8(runtime, it->name));
+  for (auto& cxxMethod : cxxMethods_) {
+    result.push_back(jsi::PropNameID::forUtf8(runtime, cxxMethod.name));
   }
   return result;
 }
@@ -164,7 +163,7 @@ jsi::Value TurboCxxModule::invokeMethod(
           args[count - 1].getObject(runtime).getFunction(runtime),
           runtime,
           jsInvoker_);
-      first = makeTurboCxxModuleCallback(runtime, wrapper);
+      first = makeTurboCxxModuleCallback(wrapper);
     } else if (method.callbacks == 2) {
       auto wrapper1 = CallbackWrapper::createWeak(
           args[count - 2].getObject(runtime).getFunction(runtime),
@@ -174,8 +173,8 @@ jsi::Value TurboCxxModule::invokeMethod(
           args[count - 1].getObject(runtime).getFunction(runtime),
           runtime,
           jsInvoker_);
-      first = makeTurboCxxModuleCallback(runtime, wrapper1);
-      second = makeTurboCxxModuleCallback(runtime, wrapper2);
+      first = makeTurboCxxModuleCallback(wrapper1);
+      second = makeTurboCxxModuleCallback(wrapper2);
     }
 
     auto innerArgs = folly::dynamic::array();
@@ -194,9 +193,9 @@ jsi::Value TurboCxxModule::invokeMethod(
           auto rejectWrapper = CallbackWrapper::createWeak(
               promise->reject_.getFunction(rt), rt, jsInvoker_);
           CxxModule::Callback resolve =
-              makeTurboCxxModuleCallback(rt, resolveWrapper);
+              makeTurboCxxModuleCallback(resolveWrapper);
           CxxModule::Callback reject =
-              makeTurboCxxModuleCallback(rt, rejectWrapper);
+              makeTurboCxxModuleCallback(rejectWrapper);
 
           auto innerArgs = folly::dynamic::array();
           for (size_t i = 0; i < count; i++) {

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModule.cpp

@@ -13,7 +13,7 @@ namespace facebook::react {
 TurboModuleMethodValueKind getTurboModuleMethodValueKind(
     jsi::Runtime& rt,
     const jsi::Value* value) {
-  if (!value || value->isUndefined() || value->isNull()) {
+  if ((value == nullptr) || value->isUndefined() || value->isNull()) {
     return VoidKind;
   } else if (value->isBool()) {
     return BooleanKind;
@@ -41,7 +41,7 @@ TurboModule::TurboModule(
 
 void TurboModule::emitDeviceEvent(
     const std::string& eventName,
-    ArgFactory argFactory) {
+    const ArgFactory& argFactory) {
   jsInvoker_->invokeAsync([eventName, argFactory](jsi::Runtime& rt) {
     jsi::Value emitter = rt.global().getProperty(rt, "__rctDeviceEventEmitter");
     if (!emitter.isUndefined()) {

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModule.h

@@ -111,7 +111,7 @@ class JSI_EXPORT TurboModule : public jsi::HostObject {
    */
   void emitDeviceEvent(
       const std::string& eventName,
-      ArgFactory argFactory = nullptr);
+      const ArgFactory& argFactory = nullptr);
 
   // Backwards compatibility version
   void emitDeviceEvent(

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.cpp

@@ -54,7 +54,7 @@ class BridgelessNativeModuleProxy : public jsi::HostObject {
      */
     std::string moduleName = name.utf8(runtime);
     if (moduleName == "__esModule") {
-      return jsi::Value(false);
+      return {false};
     }
 
     auto turboModule = turboBinding_.getModule(runtime, moduleName);

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleUtils.cpp

@@ -35,9 +35,9 @@ jsi::Value createPromiseAsJSIValue(
       2,
       [func = std::move(func)](
           jsi::Runtime& rt2,
-          const jsi::Value& thisVal,
+          const jsi::Value& /*thisVal*/,
           const jsi::Value* args,
-          size_t count) {
+          size_t /*count*/) {
         jsi::Function resolve = args[0].getObject(rt2).getFunction(rt2);
         jsi::Function reject = args[1].getObject(rt2).getFunction(rt2);
         auto wrapper = std::make_shared<Promise>(

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleUtils.h

@@ -19,7 +19,7 @@ struct Promise : public LongLivedObject {
   Promise(jsi::Runtime& rt, jsi::Function resolve, jsi::Function reject);
 
   void resolve(const jsi::Value& result);
-  void reject(const std::string& error);
+  void reject(const std::string& message);
 
   jsi::Function resolve_;
   jsi::Function reject_;

packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaInteropTurboModule.cpp

@@ -37,14 +37,15 @@ std::string getType(jsi::Runtime& rt, const jsi::Value& v) {
 
 JavaInteropTurboModule::JavaInteropTurboModule(
     const JavaTurboModule::InitParams& params,
-    std::vector<MethodDescriptor> methodDescriptors)
+    const std::vector<MethodDescriptor>& methodDescriptors)
     : JavaTurboModule(params),
       methodDescriptors_(methodDescriptors),
       methodIDs_(methodDescriptors.size()),
       constantsCache_(jsi::Value::undefined()) {
   for (const auto& methodDescriptor : methodDescriptors) {
     methodMap_[methodDescriptor.methodName] = MethodMetadata{
-        static_cast<size_t>(methodDescriptor.jsArgCount), nullptr};
+        .argCount = static_cast<size_t>(methodDescriptor.jsArgCount),
+        .invoker = nullptr};
   }
 }
 
@@ -60,7 +61,7 @@ jsi::Value JavaInteropTurboModule::create(
             static_cast<unsigned int>(methodDescriptors_[i].jsArgCount),
             [this, i](
                 jsi::Runtime& rt,
-                const jsi::Value& thisVal,
+                const jsi::Value& /*thisVal*/,
                 const jsi::Value* args,
                 size_t count) mutable {
               if (!this->constantsCache_.isUndefined()) {
@@ -103,7 +104,7 @@ jsi::Value JavaInteropTurboModule::create(
           static_cast<unsigned int>(methodDescriptors_[i].jsArgCount),
           [this, i](
               jsi::Runtime& rt,
-              const jsi::Value& thisVal,
+              const jsi::Value& /*thisVal*/,
               const jsi::Value* args,
               size_t count) {
             return this->invokeJavaMethod(