Commit cb8a461
authored
[BUG] Default create path with no config or schema does not populate default ef in schema (#5726)
## Description of changes
_Summarize the changes made by this PR._
- Improvements & Bug fixes
- There was a bug in the create collection path, where if the user
provides no configuration and no schema at create time, the default
schema (which has no ef) gets written to sysdb. this got hidden in the
tests since on deserialization, schema builds with the default ef, so
the test thought it correctly was assigned the default ef. the fix for
this is to check if both config and schema are default during
reconciliation, and in that case use the config to build the schema.
- New functionality
- ...
## Test plan
updated e2e test to catch this bug. validated the test caught the bug,
then fixed it
_How are these changes tested?_
- [ x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust
## Migration plan
_Are there any migrations, or any forwards/backwards compatibility
changes needed in order to make sure this change deploys reliably?_
## Observability plan
_What is the plan to instrument and monitor this change?_
## Documentation Changes
_Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_1 parent bf02ad7 commit cb8a461
File tree
2 files changed
+18
-3
lines changed- chromadb/test/api
- rust/types/src
2 files changed
+18
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1458 | 1458 | | |
1459 | 1459 | | |
1460 | 1460 | | |
| 1461 | + | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
1461 | 1467 | | |
1462 | 1468 | | |
1463 | 1469 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1241 | 1241 | | |
1242 | 1242 | | |
1243 | 1243 | | |
1244 | | - | |
1245 | | - | |
| 1244 | + | |
| 1245 | + | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
1246 | 1255 | | |
1247 | 1256 | | |
1248 | 1257 | | |
| |||
3346 | 3355 | | |
3347 | 3356 | | |
3348 | 3357 | | |
3349 | | - | |
3350 | 3358 | | |
| 3359 | + | |
3351 | 3360 | | |
3352 | 3361 | | |
3353 | 3362 | | |
| |||
0 commit comments