Skip to content

Verify parameter is not settable #94

@bennnnnnnn

Description

@bennnnnnnn

Summary

The verify parameter for ManagerSession is not settable. For a certain vmanage, we'd like to pass our own ca to verify the authenticity.
The parameter seems to be documented in the docstring, but is not actually settable.
It also seems that the verify parameter is set to False by default? Seems like a real bad practice.
Looking at the code it also looks like this kwarg is not passed through everywhere.

Logs and external information

Tested on version 0.41

Reproduction script

url = os.environ["VMANAGE_URL"]
username = os.environ["VMANAGE_USERNAME"]
password = os.environ["VMANAGE_PASSWORD"]

auth = vManageAuth(username, password)
with ManagerSession(base_url=url, auth=auth, verify="/some/cert/path') as session:
session.login()
config_groups = session.api.config_group.get()
print(config_groups)

On what platform(s) does it occur?

Not Applicable

Issue Severity

High: Blocking everything

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions