Revert #319

[PaulDance]

As mentioned in #319 (comment), #319 was merged a bit too quickly in my opinion: there is no real justification or discussion for it and the change it reverts was previously discussed and accepted. Would it be possible to bring it back now, potentially in a backwards-compatible way instead?

[kornelski]

We should have better documented the problem.

IIRC the issue is that this is a breaking change, due to the change in what Cargo features need to be enabled for hyper 0. vs 1. compatibility, and it did break some users.

There's a plan to release v5 with breaking changes later, and the revert was only temporary to unblock releases of v4.

[PaulDance]

IIRC the issue is that this is a breaking change

Yes, indeed. But then again, this was known and discussed in the original PR.

We should have better documented the problem.

Do you mean in the PR or afterwards in release notes?

There's a plan to release v5 with breaking changes later, and the revert was only temporary to unblock releases of v4.

That I can understand, thanks for clarifying. If I remember correctly though, this was also planned to be done just after merging the original PR.

In any case, what is the expected broad time-frame for the v5? Is there anything blocking it from being released now?

[kornelski]

@rushilmehra Is it time for v5 now?