Skip to content

Commit 5c556d8

Browse files
committed
chore(services): add todos for serivces with format needs
1 parent 3b58531 commit 5c556d8

File tree

6 files changed

+12
-1
lines changed

6 files changed

+12
-1
lines changed

src/services/cognitoIdentityPool/schema.graphql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,6 @@ type awsCognitoIdentityPool @key(fields: "id") {
3535
tags: [awsRawTag]
3636
}
3737

38+
# TODO: add an arn for identity pool see here: https://docs.aws.amazon.com/cognito/latest/developerguide/security_iam_service-with-iam.html
3839
#TODO: add connections to iamSamlProvider and iamOpenIdConnectProvider
3940
#TODO: try to add connection to iam role using getIdentityPoolRoles

src/services/efsMountTarget/schema.graphql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,6 @@ type awsEfsMountTarget @key(fields: "id") {
1212
networkInterface: [awsNetworkInterface] @hasInverse(field: efsMountTarget) #change to plural
1313
subnet: [awsSubnet] @hasInverse(field: efsMountTarget) #change to plural
1414
vpc: [awsVpc] @hasInverse(field: efsMountTarget)
15-
}
15+
}
16+
17+
# TODO: add an arn if possible

src/services/emrInstance/schema.graphql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ type awsEmrInstance @key(fields: "id") {
1616
ec2Instance: [awsEc2] @hasInverse(field: emrInstance)
1717
}
1818

19+
# TODO: add arn if possible
20+
1921
type awsEmrInstanceStatus
2022
@generate(
2123
query: { get: false, query: false, aggregate: false }

src/services/emrStep/schema.graphql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ type awsEmrStep @key(fields: "id") {
88
status: awsEmrStepStatus
99
}
1010

11+
# TODO: add arn if possible (or maybe deconvert from a service to a sub-object)
12+
1113
type awsEmrHadoopStepConfig
1214
@generate(
1315
query: { get: false, query: false, aggregate: false }

src/services/flowLogs/schema.graphql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ type awsFlowLog @key(fields: "id") {
2222
# destinationOptions: awsDestinationOptions Cant find in the aws SDK flow log type but is in docs, investigate later
2323
}
2424

25+
# TODO: add arn like so arn:aws:ec2:region:account_id:vpc-flow-log/flow-log-id
26+
2527
# type awsDestinationOptions {
2628
# fileFormat: String
2729
# hiveCompatiblePartitions: Boolean

src/services/guardDutyDetector/schema.graphql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ type awsGuardDutyDetector @key(fields: "id") {
1313
iamRole: awsIamRole @hasInverse(field: guardDutyDetectors)
1414
}
1515

16+
# TODO: add arn here. see: https://github.com/cloudquery/cq-provider-aws/blob/main/resources/services/guardduty/detectors.go
17+
1618
type awsGuardDutyMember {
1719
id: String! @id @search(by: [hash])
1820
accountId: String! @search(by: [hash])

0 commit comments

Comments
 (0)