Skip to content

TimeExpression bugs/expand coverage #21

@Daithi-stack

Description

@Daithi-stack

@year: in 2014, 12 2020, August 2020
two things to adjust:
[tag=IN] will allow expressions that could go with hours;
add neg lookahead for 'hours' to this rule.
also, any 4-digit string accepted as year, too liberal: restrict to range 17/1800-21/2200 (?)
@Date:
adjust: no 00 or 0 day/month; restrict to reasonable years

image
compare:
image
august 12 vs August 12th: parser treats differently, nummod vs. compound

Another thing to look at: some date formats chopped up into several dates, others as a single date -- fix rule, or use Action?
image

Larger set of dates:
image

"On 12 August 2021" not catching @OnTimeExpression
"starting JUN 2025" also missed
And see below: "12 2020" not caught as @Date
image

problem in TestEntities: "during the week of October 12" failing TimeExpression, IntervalExporession tests. Something about not catching whole span maybe?
[note, something that could be addressed by "catena" mechanism to find dependents of N... if it's possible to implement]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions