add tests for quota behavior

Author: prandla

.github/workflows/main.yml

@@ -26,6 +26,9 @@ jobs:
 
       - name: Run tests
         run: |
+          # github runner kernel for some reason doesn't have ext4 quota
+          # support, but does have tmpfs quotas
+          export TEST_QUOTAS=tmpfs
           docker compose -p cms -f docker/docker-compose.test.yml run --rm testcms
 
       - name: Upload test results to Codecov

cmstestsuite/Tests.py

@@ -20,6 +20,8 @@
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+import os
+
 import cmstestsuite.tasks.batch_and_output as batch_and_output
 import cmstestsuite.tasks.batch_fileio as batch_fileio
 import cmstestsuite.tasks.batch_fileio_managed as batch_fileio_managed
@@ -464,3 +466,16 @@
          checks=[CheckOverallScore(0, 100)]),
 
 ]
+
+# TODO figure out a better way to enable/disable this.........
+if os.environ.get('TEST_QUOTAS', '') != '':
+    ALL_TESTS += [
+        Test('write-many-files',
+             task=batch_fileio, filenames=['write-many-files.%l'],
+             languages=(LANG_C,),
+             checks=[CheckOverallScore(100, 100)]),
+        Test('write-big-file-quota',
+             task=batch_fileio, filenames=['write-big-file-quota.%l'],
+             languages=(LANG_C,),
+             checks=[CheckOverallScore(100, 100)])
+    ]

cmstestsuite/code/write-big-file-quota.c

@@ -0,0 +1,31 @@
+
+#include <errno.h>
+#include <stddef.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+
+int main() {
+    int n, i;
+    FILE* in = fopen("input.txt", "r");
+    fscanf(in, "%d", &n);
+
+    FILE* temp = fopen("temp.txt", "w");
+    // The quota is set to 64MB, so this should fail.
+    int size = 65*1024*1024;
+    char* buf = calloc(size, 1);
+    size_t res = fwrite(buf, 1, size, temp);
+    int write_error = errno;
+    fclose(temp);
+    // Clean up the temporary file, so that we have space for output.txt
+    unlink("temp.txt");
+    FILE* out = fopen("output.txt", "w");
+
+    if (res < size && write_error == EDQUOT) {
+        fprintf(out, "correct %d\n", n);
+        return 0;
+    } else {
+        fprintf(out, "incorrect %d\n%d", n, write_error);
+        return 0;
+    }
+}

cmstestsuite/code/write-big-fileio.c

@@ -7,7 +7,11 @@
 
 /* First we create a huge file in output.txt (2 GB). If the check on
    file size is enforced, the write fails and we write a wrong
-   output. Otherwise we write correct output. */
+   output. Otherwise we write correct output.
+
+   Note that since the file is sparse, it doesn't use up much real disk
+   space, and thus won't hit the disk quota (if that is configured).
+   */
 
 int main() {
     int n, i;

cmstestsuite/code/write-many-files.c

@@ -0,0 +1,29 @@
+#include <errno.h>
+#include <stdio.h>
+
+int main() {
+    int n, i;
+    FILE* in = fopen("input.txt", "r");
+    fscanf(in, "%d", &n);
+    fclose(in);
+
+    FILE* out = fopen("output.txt", "w");
+
+    for(i = 0; i < 1025; i++) {
+        char outname[32];
+        sprintf(outname, "out_%d.txt", i);
+        FILE* f = fopen(outname, "w");
+        if(!f && errno == EDQUOT) {
+            break;
+        }
+        if(f) fclose(f);
+    }
+
+    if (i >= 1000 && i < 1025) {
+        fprintf(out, "correct %d\n", n);
+        return 0;
+    } else {
+        fprintf(out, "incorrect %d\n", n);
+        return 0;
+    }
+}

docker/_cms-test-internal.sh

@@ -13,6 +13,29 @@ dropdb --host=testdb --username=postgres cmsdbfortesting
 createdb --host=testdb --username=postgres cmsdbfortesting
 cmsInitDB
 
+if [ -n $TEST_QUOTAS ]; then
+    sed -i 's/#fs_quota/fs_quota/' /home/cmsuser/cms/etc/cms-testdb.toml
+    # Some platforms only support quotas on ext4, some only support them
+    # on tmpfs. So pick the filesystem accordingly.
+    case $TEST_QUOTAS in
+      ext4)
+        # 5 times the disk quota: the test runs up to 4 workers
+        # concurrently; this makes sure they can't get spurious failures
+        # from running out of disk space
+        fallocate -l 320M ~/boxfs.img
+        mkfs.ext4 -O quota ~/boxfs.img
+        sudo mount -o loop,usrquota ~/boxfs.img /var/lib/isolate
+        ;;
+      tmpfs)
+        sudo mount -o usrquota -t tmpfs tmpfs /var/lib/isolate
+        ;;
+      *)
+        echo "Bad TEST_QUOTAS value (expected ext4 or tmpfs)" >&2
+        exit 1
+        ;;
+    esac
+fi
+
 cmsRunFunctionalTests -v --coverage codecov/functionaltests.xml
 FUNC=$?
 

docker/docker-compose.test.yml

@@ -14,6 +14,7 @@ services:
       # - https://github.com/pytest-dev/pytest/issues/7443
       # - https://github.com/actions/runner/issues/241
       PYTEST_ADDOPTS: --color=yes
+      TEST_QUOTAS: ${TEST_QUOTAS-ext4}
     volumes:
       - "../codecov:/home/cmsuser/src/codecov"
     privileged: true