More tests

Author: pmenon

test/codegen/csv_scan_test.cpp

@@ -32,12 +32,6 @@ struct State {
   CallbackFn callback;
 };
 
-struct TempFileHandle {
-  std::string name;
-  TempFileHandle(std::string _name) : name(_name) {}
-  ~TempFileHandle() { boost::filesystem::remove(name); }
-};
-
 void CSVRowCallback(void *s) {
   auto *state = reinterpret_cast<State *>(s);
   state->callback(state->scanner->GetColumns());

test/codegen/csv_scan_translator_test.cpp

@@ -0,0 +1,102 @@
+//===----------------------------------------------------------------------===//
+//
+//                         Peloton
+//
+//
+// csv_scan_translator_test.cpp
+//
+// Identification: test/codegen/csv_scan_translator_test.cpp
+//
+// Copyright (c) 2015-2018, Carnegie Mellon University Database Group
+//
+//===----------------------------------------------------------------------===//
+
+#include "codegen/testing_codegen_util.h"
+
+#include "planner/csv_scan_plan.h"
+#include "planner/insert_plan.h"
+#include "planner/seq_scan_plan.h"
+#include "util/file_util.h"
+
+namespace peloton {
+namespace test {
+
+class CSVScanTranslatorTest : public PelotonCodeGenTest {
+ public:
+  CSVScanTranslatorTest() : PelotonCodeGenTest() {}
+
+  oid_t TestTableId1() { return test_table_oids[0]; }
+  uint32_t NumRowsInTestTable() const { return num_rows_to_insert; }
+
+ private:
+  uint32_t num_rows_to_insert = 64;
+};
+
+TEST_F(CSVScanTranslatorTest, IntCsvScan) {
+  // Test input
+  std::vector<std::string> rows = {"1,2,3.9,four",
+                                   "5,6,7.4,eight",
+                                   "9,10,11.1,\"twelve\""};
+  std::string csv_data;
+  for (const auto &row : rows) {
+    csv_data.append(row).append("\n");
+  }
+
+  ///////////////////////////////////////////////////
+  /// First insert contents of CSV into test table
+  ///////////////////////////////////////////////////
+  {
+    // Write the contents into a temporary file
+    TempFileHandle fh{FileUtil::WriteTempFile(csv_data, "", "tmp")};
+
+    // clang-format off
+    // NOTE: this schema has to match that of the test table!
+    std::vector<planner::CSVScanPlan::ColumnInfo> cols = {
+        planner::CSVScanPlan::ColumnInfo{.name = "1", .type = peloton::type::TypeId::INTEGER},
+        planner::CSVScanPlan::ColumnInfo{.name = "2", .type = peloton::type::TypeId::INTEGER},
+        planner::CSVScanPlan::ColumnInfo{.name = "3", .type = peloton::type::TypeId::DECIMAL},
+        planner::CSVScanPlan::ColumnInfo{.name = "4", .type = peloton::type::TypeId::VARCHAR},
+    };
+    // clang-format on
+    std::unique_ptr<planner::AbstractPlan> csv_scan{
+        new planner::CSVScanPlan(fh.name, std::move(cols), ',')};
+    std::unique_ptr<planner::AbstractPlan> insert{
+        new planner::InsertPlan(&GetTestTable(TestTableId1()))};
+
+    insert->AddChild(std::move(csv_scan));
+
+    planner::BindingContext ctx;
+    insert->PerformBinding(ctx);
+
+    codegen::BufferingConsumer consumer{{0, 1, 2, 3}, ctx};
+
+    // Execute insert
+    CompileAndExecute(*insert, consumer);
+    ASSERT_EQ(0, consumer.GetOutputTuples().size());
+  }
+
+  ///////////////////////////////////////////////////
+  /// Now scan test table, comparing results
+  ///////////////////////////////////////////////////
+  {
+    std::unique_ptr<planner::AbstractPlan> scan{new planner::SeqScanPlan(
+        &GetTestTable(TestTableId1()), nullptr, {0, 1, 2, 3})};
+
+    planner::BindingContext ctx;
+    scan->PerformBinding(ctx);
+
+    codegen::BufferingConsumer consumer{{0, 1, 2, 3}, ctx};
+
+    // Execute insert
+    CompileAndExecute(*scan, consumer);
+
+    const auto &output = consumer.GetOutputTuples();
+    ASSERT_EQ(rows.size(), output.size());
+    for (uint32_t i = 0; i < rows.size(); i++) {
+      EXPECT_EQ(rows[i], output[i].ToCSV());
+    }
+  }
+}
+
+}  // namespace test
+}  // namespace peloton

test/codegen/testing_codegen_util.cpp

@@ -12,6 +12,8 @@
 
 #include "codegen/testing_codegen_util.h"
 
+#include <boost/filesystem.hpp>
+
 #include "catalog/table_catalog.h"
 #include "codegen/proxy/runtime_functions_proxy.h"
 #include "codegen/proxy/value_proxy.h"
@@ -28,6 +30,9 @@
 namespace peloton {
 namespace test {
 
+TempFileHandle::TempFileHandle(std::string _name) : name(_name) {}
+TempFileHandle::~TempFileHandle() { boost::filesystem::remove(name); }
+
 //===----------------------------------------------------------------------===//
 // PELOTON CODEGEN TEST
 //===----------------------------------------------------------------------===//

test/include/codegen/testing_codegen_util.h

@@ -6,7 +6,7 @@
 //
 // Identification: test/include/codegen/testing_codegen_util.h
 //
-// Copyright (c) 2015-17, Carnegie Mellon University Database Group
+// Copyright (c) 2015-2018, Carnegie Mellon University Database Group
 //
 //===----------------------------------------------------------------------===//
 
@@ -40,11 +40,22 @@ using ConstExpressionPtr =
 using PlanPtr = std::unique_ptr<planner::AbstractPlan>;
 using ConstPlanPtr = std::unique_ptr<const planner::AbstractPlan>;
 
-//===----------------------------------------------------------------------===//
-// Common base class for all codegen tests. This class four test tables that all
-// the codegen components use. Their ID's are available through the oid_t
-// enumeration.
-//===----------------------------------------------------------------------===//
+/**
+ * This is a scoped file handle that automatically deletes/removes the file
+ * with the given name when the class goes out of scope and the destructor is
+ * called.
+ */
+struct TempFileHandle {
+  std::string name;
+  TempFileHandle(std::string _name);
+  ~TempFileHandle();
+};
+
+/**
+ * Common base class for all codegen tests. This class four test tables that all
+ * the codegen components use. Their ID's are available through the oid_t
+ * enumeration.
+ */
 class PelotonCodeGenTest : public PelotonTest {
  public:
   std::string test_db_name = "peloton_codegen";