hsanci -> hsa-nci + add comment about min() for dedupe

Author: minhkhul

nssp/delphi_nssp/constants.py

@@ -9,7 +9,7 @@
     "state",
     "county",
     "hhs",
-    "hsanci",
+    "hsa-nci",
 ]
 
 SIGNALS_MAP = {

nssp/delphi_nssp/run.py

@@ -137,10 +137,13 @@ def run_module(params, logger=None):
                 df = geo_mapper.add_geocode(df, "state_code", "hhs", from_col="state_code", new_col="geo_id")
                 df = geo_mapper.aggregate_by_weighted_sum(df, "geo_id", "val", "timestamp", "population")
                 df = df.rename(columns={"weighted_val": "val"})
-            elif geo == "hsanci":
+            elif geo == "hsa-nci":
                 df = df[["hsa_nci_id", "val", "timestamp"]]
                 df = df[df["hsa_nci_id"] != "All"]
-                df = df.groupby(["hsa_nci_id", "timestamp"])['val'].min().reset_index()
+                # We use min() below just to pick a representative value, since all
+                # the values in a given HSA-NCI level are the same (the data is
+                # reported at the HSA-NCI level).
+                df = df.groupby(["hsa_nci_id", "timestamp"])["val"].min().reset_index()
                 df = df.rename(columns={"hsa_nci_id": "geo_id"})
             else:
                 df = df[df["county"] != "All"]