Skip to content

TEST Sonarqube properties #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 72 commits into from
Closed

TEST Sonarqube properties #1665

wants to merge 72 commits into from

Conversation

@korlaxxalrok
Copy link
Contributor

@korlaxxalrok korlaxxalrok commented Aug 14, 2025

Summary:

TEST - We are attempting to add exclusions to various code health checks.

cchuong and others added 30 commits September 12, 2024 21:21
@cchuong
Create rvdss_historic.py
62b9070
@cchuong
Create rvdss_update.py
073aac9
@cchuong
create utils.py for common functions
01af95f
@cchuong
create constants.py and update utils
6a002e0
@cchuong
Update rvdss_historic.py
714455c
@cchuong
Update rvdss_update.py
6ee8bb7
@cchuong
fix typo and add missing abbreviation to constants
8814554
@cchuong
fix typo
d7905c8
@cchuong
add missing geo
08f908a
@cchuong
Update constants.py
07ed998
@cchuong
Revert "Update constants.py"
fd5bf15 
This reverts commit 07ed998.
@cchuong
Revert "add missing geo"
678b468 
This reverts commit 08f908a.
@cchuong
fix geo and virus abbreviation
4bfc933
@cchuong
remove "province of" from geo_values
e8957c3
@nmdefries
construct urls automatically
7720a24
@nmdefries
comment constants
59f79bf
@nmdefries
note historic urls don't need to be updated
e70b0e9
@nmdefries
be stricter about importing local fns
72d1906
@nmdefries
move dashboard file names to constants
bf51bd3
@nmdefries
move run-the-whole-pipeline code into main()
ee3cadf
@cchuong
add code to calculate number of positive tests back in
180e67f
@cchuong
update abbreviate_geo to remove periods and other spelling
6bd6e24
@cchuong
fix lab name missing province
a7666b8
@nmdefries
comment historic script
503165e
@nmdefries
move output file names to constants
256e697
@nmdefries
replace boolean comparisons with pythonic "not"
cd83087
@nmdefries
actually put csv names in constants
969295b
@cchuong
break more helper functions and add doctsrings
00f3f9a
@cchuong
add more comments
ecca542
@cchuong
calculate update dates in a new function
31ec961
cchuong and others added 27 commits April 25, 2025 10:40
@cchuong
update sql keys
901b2fe
@cchuong
Update pull_historic.py
1214e70
@cchuong
Update rvdss.sql
4e5528b
@cchuong
remove unused code and table definition
908df83
@cchuong
add extra edge cases, and duplicate checking
02de2eb
@cchuong
remove saving to csv
dc14c71
@cchuong
remove scripts for manual testing
4d283a6
@cchuong
add extra duplication checks and check if tables exists
58a1478
@cchuong
add logger
f96d926
@cchuong
add basic integration tests
7cf0116
@cchuong
Combine multiple tables into one
38bdd50
@cchuong
stop scraping unused table
5ba4fd5
@cchuong
skeleton integration tests
277c44b
@cchuong
Merge pull request #1561 from cmu-delphi/ndefries/rvdss-tests
4e5a051 
Add unit tests to `rvdss`
@cchuong
Check for duplicate indexes and use merge to combine tables
f1fde56
@cchuong
test extra edge case
914862f
@cchuong
Clean up old comments
ffba810
@cchuong
cleanup old code to do with unused tables
6932653
@cchuong
update tests for new table structure
a482227
@cchuong
Update unit tests and remove unused functions/tests
48a1b5a
@cchuong
Update functions to combine tables
9641f02
@cchuong
Update unit tests to check dtype and column order
d757ed5
@cchuong
historic report data is a single dict not a list
c2389bd
@cchuong
pass both years in the season instead of the startyear
cf49a54
@korlaxxalrok
test excluding duplicates
7ecea69
@korlaxxalrok
test excluding duplicates
da0df87
@korlaxxalrok
test excluding duplicates, rename file
3e61ec1
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 27, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
40.5% Duplication on New Code (required ≤ 20%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@korlaxxalrok korlaxxalrok deleted the test-sonar-properties branch August 29, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@korlaxxalrok @cchuong @nmdefries