Skip to content

Fix markdown formatting in comment sections #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix markdown formatting in comment sections #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8232a8b
Initial plan
Copilot Jul 14, 2025
8727bc7
Fix markdown formatting in comment sections
Copilot Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/components/ui/markdown-renderer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ function isAlert(
return false;
}

const generateClassOverrides = (colorMode: ColorMode, fontSize?: string) => ({
const generateClassOverrides = (colorMode: ColorMode) => ({
h1: {
component: H1WithDivider,
props: {
Expand Down Expand Up @@ -225,7 +225,7 @@ const generateClassOverrides = (colorMode: ColorMode, fontSize?: string) => ({

p: {
props: {
className: `${fontSize === "small" ? "text-sm" : ""} font-light`,
className: "font-light",
},
},

Expand All @@ -249,7 +249,7 @@ const generateClassOverrides = (colorMode: ColorMode, fontSize?: string) => ({

span: {
props: {
className: fontSize === "small" ? "text-sm" : "",
className: "",
},
},
});
Expand Down Expand Up @@ -290,13 +290,13 @@ export default function MarkdownRenderer({
className={cn(
"relative",
prose && "prose dark:prose-invert prose-h2:mb-2",
fontSize === "small" ? "lg:prose-base" : "lg:prose-lg",
fontSize === "small" ? "prose-sm" : "lg:prose-lg",
wrapperClasses,
)}
>
<Markdown
options={{
overrides: generateClassOverrides(colorMode, fontSize),
overrides: generateClassOverrides(colorMode),
slugify: (text) => slugify(text, { lower: true }),
}}
>
Expand Down
7 changes: 7 additions & 0 deletions app/typography.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,3 +371,10 @@
}
}
}

/* Small prose variant for comments */
.prose-sm {
font-size: var(--text-sm);
line-height: 1.6;
max-width: 65ch;
}