Skip to content

Commit 856e7f5

Browse files
authored
Merge pull request #78 from AkYML/feature/library-upgrades
upgrade kotlin version to 1.8.10 & Other library updates,
2 parents 86c2d67 + 1fbe1ca commit 856e7f5

File tree

13 files changed

+30
-42
lines changed

13 files changed

+30
-42
lines changed

YChartsLib/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ plugins {
77
}
88

99
android {
10-
compileSdk = 32
10+
compileSdk = 33
1111

1212
defaultConfig {
1313
minSdk = 26
14-
targetSdk = 32
14+
targetSdk = 33
1515

1616
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
1717
}

YChartsLib/src/main/java/co/yml/charts/ui/barchart/BarChart.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,7 @@ fun BarChart(modifier: Modifier, barChartData: BarChartData) {
104104
.clickable {
105105
if (isTalkBackEnabled) {
106106
scope.launch {
107-
accessibilitySheetState.animateTo(
108-
ModalBottomSheetValue.Expanded
109-
)
107+
accessibilitySheetState.show()
110108
}
111109
}
112110
},

YChartsLib/src/main/java/co/yml/charts/ui/barchart/GroupBarChart.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,7 @@ fun GroupBarChart(modifier: Modifier, groupBarChartData: GroupBarChartData) {
100100
.clickable {
101101
if (isTalkBackEnabled) {
102102
scope.launch {
103-
accessibilitySheetState.animateTo(
104-
ModalBottomSheetValue.Expanded
105-
)
103+
accessibilitySheetState.show()
106104
}
107105
}
108106
},

YChartsLib/src/main/java/co/yml/charts/ui/combinedchart/CombinedChart.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,7 @@ fun CombinedChart(modifier: Modifier, combinedChartData: CombinedChartData) {
130130
.clickable {
131131
if (isTalkBackEnabled) {
132132
scope.launch {
133-
accessibilitySheetState.animateTo(
134-
ModalBottomSheetValue.Expanded
135-
)
133+
accessibilitySheetState.show()
136134
}
137135
}
138136
},

YChartsLib/src/main/java/co/yml/charts/ui/linechart/LineChart.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,7 @@ fun LineChart(modifier: Modifier, lineChartData: LineChartData) {
9797
.clickable {
9898
if (isTalkBackEnabled) {
9999
scope.launch {
100-
accessibilitySheetState.animateTo(
101-
ModalBottomSheetValue.Expanded
102-
)
100+
accessibilitySheetState.show()
103101
}
104102
}
105103
},

YChartsLib/src/main/java/co/yml/charts/ui/piechart/charts/DonuPieChart.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,7 @@ fun DonutPieChart(
9797
.clickable {
9898
if (isTalkBackEnabled) {
9999
scope.launch {
100-
accessibilitySheetState.animateTo(
101-
ModalBottomSheetValue.Expanded
102-
)
100+
accessibilitySheetState.show()
103101
}
104102
}
105103
}) {

YChartsLib/src/main/java/co/yml/charts/ui/piechart/charts/PieChart.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,7 @@ fun PieChart(
104104
.clickable {
105105
if (isTalkBackEnabled) {
106106
scope.launch {
107-
accessibilitySheetState.animateTo(
108-
ModalBottomSheetValue.Expanded
109-
)
107+
accessibilitySheetState.show()
110108
}
111109
}
112110
},

app/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ plugins {
44
}
55

66
android {
7-
compileSdk = 32
7+
compileSdk = 33
88

99
defaultConfig {
1010
applicationId = "co.yml.ycharts.app"
1111
minSdk = 26
12-
targetSdk = 32
12+
targetSdk = 33
1313
versionCode = 1
1414
versionName = "1.0"
1515
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"

build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ buildscript {
99
}
1010

1111
dependencies {
12-
classpath("com.android.tools.build:gradle:7.1.3")
13-
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.6.10")
14-
classpath("org.jetbrains.kotlin:kotlin-android-extensions:1.6.10")
15-
classpath("org.jetbrains.dokka:dokka-gradle-plugin:1.6.10")
12+
classpath("com.android.tools.build:gradle:7.4.2")
13+
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.10")
14+
classpath("org.jetbrains.kotlin:kotlin-android-extensions:1.8.10")
15+
classpath("org.jetbrains.dokka:dokka-gradle-plugin:1.7.20")
1616
}
1717

1818
tasks {
Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
package co.ycharts.dependency
22

33
object Version {
4-
const val CORE_KTX = "1.7.0"
5-
const val APPCOMPAT = "1.4.2"
6-
const val MATERIAL = "1.6.1"
7-
const val MATERIAL_3 = "1.0.0-alpha01"
4+
const val CORE_KTX = "1.9.0"
5+
const val APPCOMPAT = "1.6.1"
6+
const val MATERIAL = "1.8.0"
7+
const val MATERIAL_3 = "1.0.1"
88
const val JUNIT = "4.13.2"
99
const val TEST_EXTN = "1.1.3"
1010
const val ESPRESSO_CORE = "3.4.0"
11-
const val COMPOSE_COMPILER = "1.2.0"
12-
const val COMPOSE_UI = "1.2.0-rc03"
13-
const val COMPOSE_ACTIVITY = "1.3.1"
14-
const val RUNTIME_KTX = "2.3.1'"
15-
const val KOTLIN_COMPILER_EXT = "1.1.0"
16-
const val MOCKK = "1.12.5"
11+
const val COMPOSE_COMPILER = "1.4.4"
12+
const val COMPOSE_UI = "1.4.0"
13+
const val COMPOSE_ACTIVITY = "1.7.0"
14+
const val RUNTIME_KTX = "2.6.1'"
15+
const val KOTLIN_COMPILER_EXT = "1.4.4"
16+
const val MOCKK = "1.13.4"
1717
}

0 commit comments

Comments
 (0)