refactor: add @throws RedirectException in Controller::initController (#9327)

paulbalandan · web-flow · commit cc1b8f2856bb · 2024-12-19T16:33:56.000+08:00
diff --git a/system/Controller.php b/system/Controller.php
@@ -15,6 +15,7 @@
 
 use CodeIgniter\HTTP\CLIRequest;
 use CodeIgniter\HTTP\Exceptions\HTTPException;
+use CodeIgniter\HTTP\Exceptions\RedirectException;
 use CodeIgniter\HTTP\IncomingRequest;
 use CodeIgniter\HTTP\RequestInterface;
 use CodeIgniter\HTTP\ResponseInterface;
@@ -77,7 +78,7 @@ class Controller
      *
      * @return void
      *
-     * @throws HTTPException
+     * @throws HTTPException|RedirectException
      */
     public function initController(RequestInterface $request, ResponseInterface $response, LoggerInterface $logger)
     {
@@ -105,7 +106,7 @@ public function initController(RequestInterface $request, ResponseInterface $res
      *
      * @return void
      *
-     * @throws HTTPException
+     * @throws HTTPException|RedirectException
      */
     protected function forceHTTPS(int $duration = 31_536_000)
     {
diff --git a/utils/phpstan-baseline/catch.neverThrown.neon b/utils/phpstan-baseline/catch.neverThrown.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -7,7 +7,6 @@ includes:
     - booleanNot.exprNotBoolean.neon
     - booleanOr.leftNotBoolean.neon
     - booleanOr.rightNotBoolean.neon
-    - catch.neverThrown.neon
     - class.notFound.neon
     - codeigniter.cacheHandlerInstance.neon
     - codeigniter.configArgumentInstanceof.neon

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`
`16`	`16`	`use CodeIgniter\HTTP\CLIRequest;`
`17`	`17`	`use CodeIgniter\HTTP\Exceptions\HTTPException;`
	`18`	`+use CodeIgniter\HTTP\Exceptions\RedirectException;`
`18`	`19`	`use CodeIgniter\HTTP\IncomingRequest;`
`19`	`20`	`use CodeIgniter\HTTP\RequestInterface;`
`20`	`21`	`use CodeIgniter\HTTP\ResponseInterface;`
`@@ -77,7 +78,7 @@ class Controller`
`77`	`78`	`*`
`78`	`79`	`* @return void`
`79`	`80`	`*`
`80`		`- * @throws HTTPException`
	`81`	`+ * @throws HTTPException\|RedirectException`
`81`	`82`	`*/`
`82`	`83`	`public function initController(RequestInterface $request, ResponseInterface $response, LoggerInterface $logger)`
`83`	`84`	`{`
`@@ -105,7 +106,7 @@ public function initController(RequestInterface $request, ResponseInterface $res`
`105`	`106`	`*`
`106`	`107`	`* @return void`
`107`	`108`	`*`
`108`		`- * @throws HTTPException`
	`109`	`+ * @throws HTTPException\|RedirectException`
`109`	`110`	`*/`
`110`	`111`	`protected function forceHTTPS(int $duration = 31_536_000)`
`111`	`112`	`{`