Merge pull request #1250 from codeigniter4/datamweb-refactor-collectors

datamweb · web-flow · commit 4d0b6e237015 · 2025-02-28T01:16:20.000+03:30
refactor: `display()` method to enhance readability and maintainability
diff --git a/src/Collectors/Auth.php b/src/Collectors/Auth.php
@@ -75,25 +75,24 @@ public function display(): string
     {
         if ($this->auth->loggedIn()) {
             $user        = $this->auth->user();
-            $groups      = $user->getGroups();
-            $permissions = $user->getPermissions();
-
-            $groupsForUser      = implode(', ', $groups);
-            $permissionsForUser = implode(', ', $permissions);
-
-            $html = '<h3>Current User</h3>';
-            $html .= '<table><tbody>';
-            $html .= "<tr><td width=\"150\">User ID</td><td>#{$user->id}</td></tr>";
-            $html .= "<tr><td>Username</td><td>{$user->username}</td></tr>";
-            $html .= "<tr><td>Email</td><td>{$user->email}</td></tr>";
-            $html .= "<tr><td>Groups</td><td>{$groupsForUser}</td></tr>";
-            $html .= "<tr><td>Permissions</td><td>{$permissionsForUser}</td></tr>";
-            $html .= '</tbody></table>';
-        } else {
-            $html = '<p>Not logged in.</p>';
+            $groups      = implode(', ', $user->getGroups());
+            $permissions = implode(', ', $user->getPermissions());
+
+            return <<<HTML
+                    <h3>Current User</h3>
+                    <table>
+                        <tbody>
+                            <tr><td width="150">User ID</td><td>#{$user->id}</td></tr>
+                            <tr><td>Username</td><td>{$user->username}</td></tr>
+                            <tr><td>Email</td><td>{$user->email}</td></tr>
+                            <tr><td>Groups</td><td>{$groups}</td></tr>
+                            <tr><td>Permissions</td><td>{$permissions}</td></tr>
+                        </tbody>
+                    </table>
+                HTML;
         }
 
-        return $html;
+        return '<p>Not logged in.</p>';
     }
 
     /**
