Bad Words

[SnarkyDeveloper]

A lot of times people will use bad words in their names but that shouldn't be allowed.

[mollthecoder]

https://github.com/jojoee/leo-profanity
It could probably be webpacked for the browser

[codergautam]

Can you make a pr?

[SnarkyDeveloper]

Ok

[sk337]

i think i got thia i just need to know the file that handles signup requests

[SnarkyDeveloper]

@natethemaker https://github.com/swordbattle/swordbattle.io/blob/main/dist/signup.html is the signup code

[SnarkyDeveloper]

@natethemake

[rickyof2021]

Why don't we just ban then :v

[rickyof2021]

I'll just play the game and keep an eye out :v

[codergautam]

Because I dont think it's a good idea to ban people for small things

[walmartbaggg]

Either way, if you did ban people can just get a vpn :/

[mollthecoder]

Either way, if you did ban people can just get a vpn :/

That only works for IP bans. Account bans can't be bypassed using a VPN.

[SnarkyDeveloper]

Either way, if you did ban people can just get a vpn :/

That only works for IP bans. Account bans can't be bypassed using a VPN.

But they can be by creating a new account

[mollthecoder]

Either way, if you did ban people can just get a vpn :/

That only works for IP bans. Account bans can't be bypassed using a VPN.

But they can be by creating a new account

Yeah, there's no way to prevent someone from making new accounts after getting banned. However, they suffer the punishment of all their progress getting deleted. Furthermore, they lose their name.

[SnarkyDeveloper]

Either way, if you did ban people can just get a vpn :/

That only works for IP bans. Account bans can't be bypassed using a VPN.

But they can be by creating a new account

Yeah, there's no way to prevent someone from making new accounts after getting banned. However, they suffer the punishment of all their progress getting deleted. Furthermore, they lose their name.

That’s true

[walmartbaggg]

Okay and we cant make accounts in us. Because since its going towards usa server we cant make accounts. We will play as a guest.

[walmartbaggg]

I am using that.

What's your IDE?

If you use VSC I could invite you to my editor.

Sure send the invite

[transcental]

https://prod.liveshare.vsengsaas.visualstudio.com/join?30B909281DF0D9B452F5182E8FCF3671290A

[walmartbaggg]

Whats your discord

[transcental]

Don't have one. Use the chat in VSC.

[codergautam]

@DillonB07 @FishyMine Yeah if you want to make accounts, you need to set the client to connect to localhost. Go to GameScene.js (line 451), and set it to io(undefined like in screenshot

Make sure to run npm run build!

[codergautam]

This way the client connects to the local server, adding data into the database.

[transcental]

Thanks!

[mollthecoder]

I'd say that this discussion would be more worthy of the medium priory, because this wouldn't be as bad as say, botting and hacking vulnerabilities.

[walmartbaggg]

@mollthecoder this is bad words, and its a huge problem and needs to be done very soon. A lot of kids play the game and people put their names as cuss words. I shown a picture of someone making their username "I HATE N*GG(im not saying rest but you know what I mean)

[transcental]

I agree with @FishyMine . This is a huge problem.

I hope that I can finish it this week. I don't think it should be too hard, but you never know with JS.
My solution will be to use a library that I'll pass the username through and it will change the bad words to *****.
I'll do it in the chat as well, but that is a lower priority.

We will need to manually moderate the existing accounts though.

[mollthecoder]

@DillonB07 There's no harm in using var. I understand about hoisting but that only happens if you do very questionable things in your code.

[mollthecoder]

Feel free to give it a go

Possibly, but I'm not sure how you'd do that.

The username can be detected on calls to /api/login and it's brother events in index.js

[transcental]

The username can be detected on calls to /api/login and it's brother events in index.js

Yes. I get that bit. I don't understand how you would force the user to change the username.

[codergautam]

I'm just used to var lol, and sure formatting is always a good thing. It's fine if you want to change it to let or const. I'm trying to get eslint to work so I can fix all of those little things.

[mollthecoder]

The username can be detected on calls to /api/login and it's brother events in index.js

Yes. I get that bit. I don't understand how you would force the user to change the username.

Most likely a modification on the client so that the user can type a new username. The server can handle everything else though to minimize security risk.

[transcental]

#110 will close this.

[walmartbaggg]

yep

[SnarkyDeveloper]

Do you mind giving me contibutor plz @codergautam

[transcental]

You have to fork and create a PR

[SnarkyDeveloper]

ok

[codergautam]

I believe this has been fixed by @DillonB07

thanks!