feat: code cleanup and test's refactor

lordelogos · lordelogos · commit 147a2f58fcce · 2023-09-17T04:41:03.000+01:00
diff --git a/.DS_Store b/.DS_Store
diff --git a/__tests__/parseMarkdownToReactEmailJSX.test.ts b/__tests__/parseMarkdownToReactEmailJSX.test.ts
@@ -63,8 +63,8 @@ console.log(\`Hello, \$\{name\}!\`);
 <li>Unordered List Item 2</li>
 <li>Unordered List Item 3</li>
 </ul>
-<h2 style=\"font-weight:500;padding-top:20px;font-size:2rem\">Links</h2><p><a style=\"color:#007bff;text-decoration:underline;background-color:transparent\" href=\"https://www.markdownguide.org\" target=\"_blank\">Markdown Guide</a></p>
-<h2 style=\"font-weight:500;padding-top:20px;font-size:2rem\">Images</h2><p><img alt=\"Markdown Logo\" src=\"https://markdown-here.com/img/icon256.png\"></p>
+<h2 style=\"font-weight:500;padding-top:20px;font-size:2rem\">Links</h2><p><a href=\"https://www.markdownguide.org\" target=\"_blank\" style=\"color:#007bff;text-decoration:underline;background-color:transparent\">Markdown Guide</a></p>
+<h2 style=\"font-weight:500;padding-top:20px;font-size:2rem\">Images</h2><p><img src=\"https://markdown-here.com/img/icon256.png\" alt=\"Markdown Logo\"></p>
 <h2 style=\"font-weight:500;padding-top:20px;font-size:2rem\">Blockquotes</h2><blockquote style=\"background:#f9f9f9;border-left:10px solid #ccc;margin:1.5em 10px;padding:1em 10px\">
 <p>This is a blockquote.</p>
 <ul>
@@ -232,12 +232,12 @@ greet("World")
 
   it("handles blockquotes correctly", () => {
     const markdown = `A  example:
-> Here's a block quote:
+> Here\'s a block quote:
 > Lorem ipsum dolor sit amet, consectetur adipiscing elit.`;
 
     const expected = `<p>A  example:</p>
 <blockquote style="background:#f9f9f9;border-left:10px solid #ccc;margin:1.5em 10px;padding:1em 10px">
-<p>Here's a block quote:
+<p>Here&#39;s a block quote:
 Lorem ipsum dolor sit amet, consectetur adipiscing elit.</p>
 </blockquote>
 `;
@@ -264,10 +264,10 @@ Lorem ipsum dolor sit amet, consectetur adipiscing elit.</p>
 
   it("handles links correctly", () => {
     const markdown = `A link example:
-Here's a link to [OpenAI's website](https://openai.com/).`;
+Here's a link to [OpenAI\'s website](https://openai.com/).`;
 
     const expected = `<p>A link example:
-Here's a link to <a style="color:#007bff;text-decoration:underline;background-color:transparent" href="https://openai.com/" target="_blank">OpenAI's website</a>.</p>
+Here&#39;s a link to <a href="https://openai.com/" target="_blank" style="color:#007bff;text-decoration:underline;background-color:transparent">OpenAI&#39;s website</a>.</p>
 `;
 
     const rendered = parseMarkdownToReactEmailJSX({
diff --git a/__tests__/reactEmailMarkdown.test.tsx b/__tests__/reactEmailMarkdown.test.tsx
@@ -8,7 +8,7 @@ describe("ReactEmailMarkdown component renders correctly", () => {
       <ReactEmailMarkdown markdown={`# Hello, World!`} />
     );
     expect(actualOutput).toMatchInlineSnapshot(
-      `"<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><div><h1 data-id="react-email-heading" style="font-weight:500;padding-top:20px;font-size:2.5rem">Hello, World!</h1></div>"`
+      `"<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><div><h1 style="font-weight:500;padding-top:20px;font-size:2.5rem" data-id="react-email-heading">Hello, World!</h1></div>"`
     );
   });
 });
diff --git a/src/utils.ts b/src/utils.ts
@@ -154,7 +154,7 @@ export const initRenderer = ({
         parseCssInJsToInlineCss(finalStyles.image) !== ""
           ? ` style="${parseCssInJsToInlineCss(finalStyles.image)}"`
           : ""
-      } />`;
+      }>`;
       return out;
     },
 
@@ -179,7 +179,7 @@ export const initRenderer = ({
         "<" +
         type +
         startatt +
-        `${styles !== "" ? ` style="${styles}"` : ""} >\n` +
+        `${styles !== "" ? ` style="${styles}"` : ""}>\n` +
         body +
         "</" +
         type +
