Add more tests for 404 and fallback behavior

Author: ivanvermeyen

tests/Stubs/views/errors/404.blade.php

@@ -0,0 +1 @@
+{{ App::getLocale() }}

tests/Unit/Macros/LocalizedUrlMacroTest.php

@@ -6,7 +6,9 @@
 use CodeZero\LocalizedRoutes\Tests\Stubs\Model;
 use CodeZero\LocalizedRoutes\Tests\Stubs\ModelWithCustomRouteParameters;
 use CodeZero\LocalizedRoutes\Tests\TestCase;
+use Illuminate\Database\Eloquent\ModelNotFoundException;
 use Illuminate\Support\Facades\App;
+use Illuminate\Support\Facades\Config;
 use Illuminate\Support\Facades\Route;
 use Illuminate\Support\Facades\View;
 
@@ -296,6 +298,94 @@ public function the_macro_does_not_blow_up_on_a_default_404_error()
         $response->assertResponseHasNoView();
     }
 
+    /** @test */
+    public function a_404_is_not_localized_when_triggered_by_a_non_existing_route()
+    {
+        $this->setSupportedLocales(['en', 'nl']);
+        $this->setUseLocaleMiddleware(true);
+        $this->setAppLocale('en');
+        $this->setCustomErrorViewPath();
+
+        $response = $this->get('/nl/abort');
+        $response->assertNotFound();
+        $response->assertResponseHasNoView();
+        $this->assertEquals('en', trim($response->original));
+    }
+
+    /** @test */
+    public function a_404_is_localized_when_a_registered_route_throws_a_not_found_exception()
+    {
+        $this->setSupportedLocales(['en', 'nl']);
+        $this->setUseLocaleMiddleware(true);
+        $this->setAppLocale('en');
+        $this->setCustomErrorViewPath();
+
+        Route::localized(function () {
+            Route::get('abort', function () {
+                abort(404);
+            });
+        });
+
+        $response = $this->get('/nl/abort');
+        $response->assertNotFound();
+        $response->assertResponseHasNoView();
+        $this->assertEquals('nl', trim($response->original));
+    }
+
+    /** @test */
+    public function a_404_is_localized_when_a_registered_route_throws_a_model_not_found_exception()
+    {
+        $this->setSupportedLocales(['en', 'nl']);
+        $this->setUseLocaleMiddleware(true);
+        $this->setAppLocale('en');
+        $this->setCustomErrorViewPath();
+
+        Route::localized(function () {
+            Route::get('route/{model}', function ($model) {
+                throw new ModelNotFoundException();
+            });
+        });
+
+        $response = $this->get('/nl/route/mismatch');
+        $response->assertNotFound();
+        $response->assertResponseHasNoView();
+        $this->assertEquals('nl', trim($response->original));
+    }
+
+    /** @test */
+    public function a_fallback_route_is_not_triggered_when_a_registered_route_throws_a_not_found_exception()
+    {
+        Route::get('abort', function () {
+            return abort(404);
+        });
+
+        Route::fallback(function () {
+            return 'fallback';
+        });
+
+        $response = $this->get('/abort');
+        $response->assertNotFound();
+        $response->assertResponseHasNoView();
+        $this->assertNotEquals('fallback', $response->original);
+    }
+
+    /** @test */
+    public function a_fallback_route_is_not_triggered_when_a_registered_route_throws_a_model_not_found_exception()
+    {
+        Route::get('route/{model}', function ($model) {
+            throw new ModelNotFoundException();
+        });
+
+        Route::fallback(function () {
+            return 'fallback';
+        });
+
+        $response = $this->call('GET', '/route/mismatch');
+        $response->assertNotFound();
+        $response->assertResponseHasNoView();
+        $this->assertNotEquals('fallback', $response->original);
+    }
+
     /** @test */
     public function it_returns_a_localized_url_for_a_localized_fallback_route()
     {
@@ -415,4 +505,14 @@ public function it_returns_a_localized_url_for_a_non_localized_fallback_route_wh
             'nl' => 'http://nl.domain.test/en/non/existing/route',
         ], $response->original);
     }
+
+    /**
+     * Set a custom view path so Laravel will find our custom 440 error view.
+     *
+     * @return void
+     */
+    protected function setCustomErrorViewPath()
+    {
+        Config::set('view.paths', __DIR__ . '/../../Stubs/views');
+    }
 }