#58 Added error message if JSON decode failed for both pattern and value (#85)

Author: partikus

src/Matcher/JsonMatcher.php

@@ -29,6 +29,12 @@ public function match($value, $pattern)
         }
 
         if (!Json::isValid($value)) {
+            $this->error = sprintf("Invalid given JSON of value. %s", $this->getErrorMessage());
+            return false;
+        }
+
+        if (!Json::isValidPattern($pattern) ) {
+            $this->error = sprintf("Invalid given JSON of pattern. %s", $this->getErrorMessage());
             return false;
         }
 
@@ -49,4 +55,22 @@ public function canMatch($pattern)
     {
         return Json::isValidPattern($pattern);
     }
+
+    private function getErrorMessage()
+    {
+        switch(json_last_error()) {
+            case JSON_ERROR_DEPTH:
+                return 'Maximum stack depth exceeded';
+            case JSON_ERROR_STATE_MISMATCH:
+                return 'Underflow or the modes mismatch';
+            case JSON_ERROR_CTRL_CHAR:
+                return 'Unexpected control character found';
+            case JSON_ERROR_SYNTAX:
+                return 'Syntax error, malformed JSON';
+            case JSON_ERROR_UTF8:
+                return 'Malformed UTF-8 characters, possibly incorrectly encoded';
+            default:
+                return 'Unknown error';
+        }
+    }
 }

tests/Matcher/JsonMatcherTest.php

@@ -113,6 +113,26 @@ public function test_error_when_path_in_nested_value_does_not_exist()
         $this->assertEquals($this->matcher->getError(), 'There is no element under path [foo][bar][faz] in value.');
     }
 
+    public function test_error_when_json_pattern_is_invalid()
+    {
+        $value = '{"test": "value"}';
+        $pattern = '{"test": "@string@",}';
+
+        $this->assertFalse($this->matcher->match($value, $pattern));
+
+        $this->assertEquals($this->matcher->getError(), 'Invalid given JSON of pattern. Syntax error, malformed JSON');
+    }
+
+    public function test_error_when_json_value_is_invalid()
+    {
+        $value = '{"test": "value",}';
+        $pattern = '{"test": "@string@"}';
+
+        $this->assertFalse($this->matcher->match($value, $pattern));
+
+        $this->assertEquals($this->matcher->getError(), 'Invalid given JSON of value. Syntax error, malformed JSON');
+    }
+
     public static function positivePatterns()
     {
         return array(