Skip to content

Commit 0bbb660

Browse files
committed
refactor: remove deprecated .upper() and .lower() methods
Removes backward-compatible .upper() and .lower() methods in favor of the more Swifty .uppercased() and .lowercased() API. ## Changes - Removed QueryExpression extension with .upper() and .lower() - Updated tests to use .uppercased() and .lowercased() - All 860 tests passing ## API Migration - .upper() → .uppercased() - .lower() → .lowercased() Users should use the Swifty API which matches Swift.String conventions.
1 parent 29d5944 commit 0bbb660

File tree

2 files changed

+4
-34
lines changed

2 files changed

+4
-34
lines changed

Sources/StructuredQueriesPostgres/Functions/String/String+CaseConversion.swift

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -97,36 +97,6 @@ extension PostgreSQL.String {
9797

9898
// MARK: - QueryExpression Extension (Fluent API)
9999

100-
extension QueryExpression where QueryValue: _OptionalPromotable<Swift.String?> {
101-
/// Converts the string to lowercase
102-
///
103-
/// PostgreSQL's `lower()` function.
104-
///
105-
/// ```swift
106-
/// User.select { $0.email.lower() }
107-
/// // SELECT lower("users"."email") FROM "users"
108-
/// ```
109-
///
110-
/// - Returns: An expression wrapped with the `lower` function.
111-
public func lower() -> some QueryExpression<QueryValue> {
112-
QueryFunction("lower", self)
113-
}
114-
115-
/// Converts the string to uppercase
116-
///
117-
/// PostgreSQL's `upper()` function.
118-
///
119-
/// ```swift
120-
/// User.select { $0.name.upper() }
121-
/// // SELECT upper("users"."name") FROM "users"
122-
/// ```
123-
///
124-
/// - Returns: An expression wrapped with the `upper` function.
125-
public func upper() -> some QueryExpression<QueryValue> {
126-
QueryFunction("upper", self)
127-
}
128-
}
129-
130100
extension QueryExpression where QueryValue == Swift.String {
131101
/// Converts the string to uppercase
132102
///

Tests/StructuredQueriesPostgresTests/Functions/String/StringFunctionsTests.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ extension SnapshotTests.StringFunctions {
2424

2525
// MARK: - Case Conversion Tests
2626

27-
@Test func upper() async {
27+
@Test func uppercased() async {
2828
await assertSQL(
29-
of: Person.select { $0.name.upper() }
29+
of: Person.select { $0.name.uppercased() }
3030
) {
3131
"""
3232
SELECT upper("persons"."name")
@@ -35,9 +35,9 @@ extension SnapshotTests.StringFunctions {
3535
}
3636
}
3737

38-
@Test func lower() async {
38+
@Test func lowercased() async {
3939
await assertSQL(
40-
of: Person.select { $0.email.lower() }
40+
of: Person.select { $0.email.lowercased() }
4141
) {
4242
"""
4343
SELECT lower("persons"."email")

0 commit comments

Comments
 (0)