Skip to content

Bypassed Storage Permission Check for Shared Images #6543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 8, 2025
+12 −3
Merged

Bypassed Storage Permission Check for Shared Images #6543

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d51ddb9
Bypassed Storage Perms Check for External Share
doug-doug-doug Oct 26, 2025
2b7e032
Removed Unnecessary Local Variable
doug-doug-doug Nov 2, 2025
34025e6
Merge branch 'main' into 6437-bypass-check-storage-perms-on-external-…
RitikaPahwa4444 Nov 2, 2025
f7e67c6
Moved Bypass to the Start of checkStoragePermissions()
doug-doug-doug Nov 2, 2025
b8f3568
Merge remote-tracking branch 'origin/6437-bypass-check-storage-perms-…
doug-doug-doug Nov 2, 2025
a1fcbe9
Removed Duplicate Check in receiveSharedItems
doug-doug-doug Nov 2, 2025
4237070
Merge branch 'main' into 6437-bypass-check-storage-perms-on-external-…
RitikaPahwa4444 Nov 3, 2025
9263c55
Merge branch 'main' into 6437-bypass-check-storage-perms-on-external-…
RitikaPahwa4444 Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,15 @@ class UploadActivity : BaseActivity(), UploadContract.View, UploadBaseFragment.C
// Check if all required permissions are granted
val hasAllPermissions = hasPermission(this, PERMISSIONS_STORAGE)
val hasPartialAccess = hasPartialAccess(this)

// The share intent provides files via content uris with temporary read permissions,
// so we do not need to obtain storage permissions
val action = intent.action
if (Intent.ACTION_SEND == action || Intent.ACTION_SEND_MULTIPLE == action) {
Copy link

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI visibility for binding.cvContainerTopCard is not set when handling share intents. In the normal flow (line 330), binding.cvContainerTopCard.visibility is set to View.VISIBLE after permissions are granted and receiveSharedItems() is called. The share intent path should also set this visibility to ensure consistent UI behavior. Consider adding binding.cvContainerTopCard.visibility = View.VISIBLE before calling receiveSharedItems().

Suggested change
if (Intent.ACTION_SEND == action || Intent.ACTION_SEND_MULTIPLE == action) {
if (Intent.ACTION_SEND == action || Intent.ACTION_SEND_MULTIPLE == action) {
binding.cvContainerTopCard.visibility = View.VISIBLE

Copilot uses AI. Check for mistakes.
receiveSharedItems()
return
}
Comment on lines 317 to 322
Copy link

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check duplicates the logic already present in receiveSharedItems() (lines 485-486). The receiveSharedItems() method already checks for the same intent actions to call receiveExternalSharedItems(). Consider refactoring to avoid this duplication, perhaps by extracting an isShareIntent() helper method or restructuring the permission check flow.

Copilot uses AI. Check for mistakes.

if (hasAllPermissions || hasPartialAccess) {
// All required permissions are granted, so enable UI elements and perform actions
receiveSharedItems()
Expand Down